Skip to content

Commit

Permalink
feat(prettier): follow Prettier default settings as possible (#203)
Browse files Browse the repository at this point in the history
- Changed settings:
  - `semi`: `false` -> `true`
  - `singleQuote`: `true` -> `false`
- Introduce Prettier config file (`.prettierrc.js`)
- Remove remote package test which is always failed
  • Loading branch information
ybiquitous authored May 3, 2018
1 parent 98afab2 commit 09d2590
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 30 deletions.
4 changes: 2 additions & 2 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
extends: ['@commitlint/config-conventional'],
}
extends: ["@commitlint/config-conventional"],
};
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('./node')
module.exports = require("./node");
3 changes: 3 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module.exports = {
trailingComma: "es5",
};
21 changes: 7 additions & 14 deletions base.js
Original file line number Diff line number Diff line change
@@ -1,26 +1,19 @@
module.exports = {
extends: [
'airbnb',
'plugin:eslint-comments/recommended',
'prettier',
'prettier/react',
"airbnb",
"plugin:eslint-comments/recommended",
"prettier",
"prettier/react",
],

plugins: ['prettier'],
plugins: ["prettier"],

env: {
browser: true,
node: true,
},

rules: {
'prettier/prettier': [
'error',
{
semi: false,
singleQuote: true,
trailingComma: 'es5',
},
],
"prettier/prettier": "error",
},
}
};
8 changes: 4 additions & 4 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
module.exports = {
extends: ['./base.js'],
extends: ["./base.js"],

plugins: ['compat'],
plugins: ["compat"],

rules: {
'compat/compat': 'error',
"compat/compat": "error",
},
}
};
6 changes: 3 additions & 3 deletions node.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
extends: ['./base.js', 'plugin:node/recommended'],
extends: ["./base.js", "plugin:node/recommended"],

plugins: ['node'],
}
plugins: ["node"],
};
7 changes: 1 addition & 6 deletions test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,14 @@ EOF
PATH="$(npm bin):${PATH}"
export PATH

# test local
npm install eslint prettier "file:./${tarball}" >/dev/null
echo 'process.stdout.write(1)' > test.js
echo 'process.stdout.write(1);' > test.js
echo '{"extends":"ybiquitous/base"}' > .eslintrc && eslint .
echo '{"extends":"ybiquitous"}' > .eslintrc && eslint .
for file in node_modules/eslint-config-ybiquitous/*.js; do
eslint --print-config "$file" >/dev/null
echo "test: eslint --print-config ${file} ... ok"
done

# test remote
npm install "github:ybiquitous/eslint-config-ybiquitous" >/dev/null
eslint .
}

# teardown
Expand Down

0 comments on commit 09d2590

Please sign in to comment.