test: improve E2E test (#412)

- More accurate versions of peer dependencies which are installed.
- More accurate `eslint` path in a working directory.
- Don't use unsafe `shell: true` option of `execa`.

package.json

@@ -38,6 +38,7 @@
     "eslint-find-rules": "3.3.1",
     "execa": "1.0.0",
     "prettier": "1.18.2",
+    "semver": "^6.1.2",
     "tape": "4.10.2",
     "typescript": "3.5.2",
     "ybiq": "8.0.0"

test/e2e.test.js

@@ -1,6 +1,7 @@
 const path = require("path");
 const fs = require("fs");
 const { EOL } = require("os");
+const semver = require("semver");
 const test = require("tape");
 const pkg = require("../package.json");
 const { sandbox, $, lintConfigFiles } = require("./helper");
@@ -21,16 +22,22 @@ cache-min=9999
 test("End-to-End", t => {
   const tarball = $("npm", "pack");
   const tarballPath = `file:${path.join(baseDir, tarball)}`;
+  const peerDeps = Object.entries(pkg.peerDependencies).map(([name, verRange]) => {
+    const ver = semver.valid(semver.coerce(verRange));
+    return `${name}@${ver}`;
+  });
 
-  sandbox(() => {
+  sandbox(cwd => {
     fs.writeFileSync(".npmrc", npmrc);
 
     $("npm", "init", "--yes", "--no-init-module");
-    $("npm", "install", ...Object.keys(pkg.peerDependencies), tarballPath);
+    $("npm", "install", ...peerDeps, tarballPath);
+
+    const eslint = path.join(cwd, "node_modules", ".bin", "eslint");
 
     writeESLintConfig({ extends: "ybiquitous" });
     writeLintTargetFile("process.stdout.write(1);");
-    $("eslint", ".");
+    $(eslint, ".");
     t.pass("default configuration");
 
     lintConfigFiles
@@ -39,12 +46,12 @@ test("End-to-End", t => {
         const configName = `ybiquitous/${path.basename(file, ".js")}`;
         writeESLintConfig({ extends: configName });
         writeLintTargetFile("process.stdout.write(1);");
-        $("eslint", ".");
+        $(eslint, ".");
         t.pass(`${configName} configuration`);
       });
 
     lintConfigFiles.forEach(file => {
-      $("eslint", "--print-config", path.join("node_modules", "eslint-config-ybiquitous", file));
+      $(eslint, "--print-config", path.join("node_modules", "eslint-config-ybiquitous", file));
       t.pass(`verify configuration for ${file}`);
     });
   });

test/helper.js

@@ -14,8 +14,8 @@ const log = msg => {
 };
 
 const $ = (cmd, ...args) => {
-  log(`> ${[cmd, ...args].join(" ")}`);
-  const { stdout } = execa.sync(cmd, args, { shell: true });
+  log(`> ${cmd} '${args.join("' '")}'`);
+  const { stdout } = execa.sync(cmd, args);
   const maxLines = 20;
   const lines = stdout.split(EOL);
   if (lines.length < maxLines) {