Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sub dependencies #439

Merged
merged 2 commits into from
Jun 29, 2021
Merged

fix: sub dependencies #439

merged 2 commits into from
Jun 29, 2021

Conversation

ybiquitous
Copy link
Owner

@ybiquitous ybiquitous commented Jun 29, 2021

This change aims to fix the following case when the same packages have different locations.

node_modules/svgo/node_modules/css-select:css-select@3.1.2
node_modules/css-select:css-select@4.1.3

This change aims to fix the following case when the same packages has different locations.

```
node_modules/svgo/node_modules/css-select:css-select@3.1.2
node_modules/css-select:css-select@4.1.3
```
lines += data.toString();
const returnCode = await exec(
"npm",
npmArgs("ls", "--parseable", "--long", "--all", "--package-lock-only"),
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[note] --package-lock-only does not scan node_modules. See:
https://docs.npmjs.com/cli/v7/commands/npm-ls#package-lock-only

@ybiquitous ybiquitous merged commit 5d970e8 into main Jun 29, 2021
@ybiquitous ybiquitous deleted the fix-sub-deps branch June 29, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant