feat: add configurable user and email #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ninerian
force-pushed
the
git-user-token-config
branch
from
1157b46 to
f0fbaf7
Compare
ybiquitous
requested changes
Oct 8, 2021
There was a problem hiding this comment.
@Ninerian Thanks for extracting the PR!
I'd like to keep the backward compatibility, so how about changing the default values like this?
ybiquitous
reviewed
Oct 8, 2021
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
reviewed
Oct 8, 2021
|
And, can you merge the |
ybiquitous
changed the title
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
ybiquitous
approved these changes
Oct 11, 2021
|
v3.3.0 released! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have I done
Added
github_userandgithub_emailinputsWhy was this done
I discovered the problem that checks where not running, when the PR is created by the Github Actions user. Using a custom one solved the problem