Skip to content

Commit

Permalink
fix(markdownlint): stop writing CHANGELOG.md before release (#111)
Browse files Browse the repository at this point in the history
via `--ignore` option of `markdownlint` command.
  • Loading branch information
ybiquitous authored Feb 5, 2018
1 parent e09ed1e commit 1baf050
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 31 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<!-- markdownlint-disable -->
# Change Log

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
Expand Down
8 changes: 2 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"lint-staged": "^6.0.0",
"markdownlint-cli": "^0.7.0",
"npm-run-all": "^4.1.2",
"prepend-file-cli": "^1.0.6",
"prettier": "^1.10.2",
"semver": "^5.5.0",
"standard-version": "^4.3.0",
Expand All @@ -59,7 +58,7 @@
"test:coverage": "nyc report --reporter=text-lcov > coverage.lcov",
"lint:js": "eslint --ignore-path .gitignore --ext .js,.jsx,.mjs .",
"lint:js:fix": "npm run lint:js -- --fix",
"lint:md": "markdownlint --ignore node_modules \"**/*.md\"",
"lint:md": "markdownlint --ignore node_modules --ignore CHANGELOG.md \"**/*.md\"",
"lint": "npm-run-all --print-name --print-label --parallel lint:*",
"commitmsg": "commitlint -e $GIT_PARAMS",
"precommit": "lint-staged",
Expand All @@ -74,10 +73,7 @@
"*.md": "markdownlint"
},
"standard-version": {
"message": "chore(release): new version %s",
"scripts": {
"postchangelog": "prepend CHANGELOG.md \"<!-- markdownlint-disable -->\n\""
}
"message": "chore(release): new version %s"
},
"nyc": {
"exclude": [
Expand Down
6 changes: 2 additions & 4 deletions test/init.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ suite('init', () => {
commitmsg: 'commitlint -e $GIT_PARAMS',
'lint:js': 'eslint --ignore-path .gitignore --ext .js,.jsx,.mjs .',
'lint:js:fix': 'npm run lint:js -- --fix',
'lint:md': 'markdownlint --ignore node_modules "**/*.md"',
'lint:md':
'markdownlint --ignore node_modules --ignore CHANGELOG.md "**/*.md"',
lint: 'npm-run-all --print-name --print-label --parallel lint:*',
precommit: 'lint-staged',
release: 'standard-version',
Expand All @@ -61,9 +62,6 @@ suite('init', () => {

assert.deepStrictEqual(pkg['standard-version'], {
message: 'chore(release): new version %s',
scripts: {
postchangelog: 'prepend CHANGELOG.md "<!-- markdownlint-disable -->\n"',
},
})
})

Expand Down
21 changes: 1 addition & 20 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3401,7 +3401,7 @@ os-locale@^2.0.0:
lcid "^1.0.0"
mem "^1.1.0"

os-tmpdir@^1.0.0, os-tmpdir@~1.0.1, os-tmpdir@~1.0.2:
os-tmpdir@^1.0.0, os-tmpdir@~1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/os-tmpdir/-/os-tmpdir-1.0.2.tgz#bbe67406c79aa85c5cfec766fe5734555dfa1274"

Expand Down Expand Up @@ -3570,19 +3570,6 @@ prelude-ls@~1.1.2:
version "1.1.2"
resolved "https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.1.2.tgz#21932a549f5e52ffd9a827f570e04be62a97da54"

prepend-file-cli@^1.0.6:
version "1.0.6"
resolved "https://registry.yarnpkg.com/prepend-file-cli/-/prepend-file-cli-1.0.6.tgz#ff7e116c9314db85c22c43a2a07f3f9387a9a74f"
dependencies:
minimist "^1.2.0"
prepend-file "1.3.1"

prepend-file@1.3.1:
version "1.3.1"
resolved "https://registry.yarnpkg.com/prepend-file/-/prepend-file-1.3.1.tgz#83b16e0b4ac1901fce88dbd945a22f4cc81df579"
dependencies:
tmp "0.0.31"

preserve@^0.2.0:
version "0.2.0"
resolved "https://registry.yarnpkg.com/preserve/-/preserve-0.2.0.tgz#815ed1f6ebc65926f865b310c0713bcb3315ce4b"
Expand Down Expand Up @@ -4281,12 +4268,6 @@ through@2, "through@>=2.2.7 <3", through@^2.3.6, through@~2.3, through@~2.3.1:
version "2.3.8"
resolved "https://registry.yarnpkg.com/through/-/through-2.3.8.tgz#0dd4c9ffaabc357960b1b724115d7e0e86a2e1f5"

tmp@0.0.31:
version "0.0.31"
resolved "https://registry.yarnpkg.com/tmp/-/tmp-0.0.31.tgz#8f38ab9438e17315e5dbd8b3657e8bfb277ae4a7"
dependencies:
os-tmpdir "~1.0.1"

tmp@^0.0.33:
version "0.0.33"
resolved "https://registry.yarnpkg.com/tmp/-/tmp-0.0.33.tgz#6d34335889768d21b2bcda0aa277ced3b1bfadf9"
Expand Down

0 comments on commit 1baf050

Please sign in to comment.