handle errors and refactor

Author: ybirader

main.go

@@ -2,7 +2,6 @@ package main
 
 import (
 	"archive/zip"
-	"fmt"
 	"io"
 	"os"
 )
@@ -16,10 +15,19 @@ func NewArchiver(archive *os.File) *Archiver {
 	return &Archiver{Dest: archive, w: zip.NewWriter(archive)}
 }
 
-func (a *Archiver) Archive(r io.Reader) {
-	writer, _ := a.w.Create("hello.txt")
-	fmt.Fprint(writer, r)
+func (a *Archiver) Archive(r io.Reader) error {
+	writer, err := a.w.Create("hello.txt")
+	if err != nil {
+		return err
+	}
+
+	_, err = io.Copy(writer, r)
+	if err != nil {
+		return err
+	}
+
 	a.w.Close()
+	return nil
 }
 
 func main() {

main_test.go

@@ -5,6 +5,7 @@ import (
 	"bytes"
 	"fmt"
 	"os"
+	"strings"
 	"testing"
 
 	"github.com/alecthomas/assert/v2"
@@ -31,7 +32,8 @@ func TestArchive(t *testing.T) {
 	})
 
 	t.Run("archives a single non-empty file called hello.txt", func(t *testing.T) {
-		file := bytes.NewBufferString("hello, world!")
+		fileContent := "hello, world!"
+		file := strings.NewReader(fileContent)
 		archive, cleanup := createTempArchive(t, archivePath)
 		defer cleanup()
 
@@ -42,7 +44,7 @@ func TestArchive(t *testing.T) {
 		defer archiveReader.Close()
 
 		got := archiveReader.File[0].UncompressedSize64
-		want := uint64(file.Len())
+		want := uint64(len(fileContent))
 
 		assert.Equal(t, want, got, "expected %s to have size %d but got %d", "hello.txt", want, got)
 	})