refactor: add overflow interface

Author: ybirader

archiver.go

@@ -184,9 +184,8 @@ func (a *Archiver) compress(file *pool.File) error {
 		return errors.New("ERROR: could not create compressor")
 	}
 	hasher := crc32.NewIEEE()
-	w := io.MultiWriter(compressor, hasher)
 
-	err = a.copy(w, file)
+	err = a.copy(io.MultiWriter(compressor, hasher), file)
 	if err != nil {
 		return errors.Wrapf(err, "ERROR: could not read file %s", file.Path)
 	}

archiver_test.go

@@ -164,10 +164,6 @@ func TestCompress(t *testing.T) {
 		assert.True(t, file.Overflowed())
 		assertGreaterThan(t, file.Written(), int64(file.CompressedData.Len()))
 		assert.Equal(t, file.Written(), int64(file.Header.CompressedSize64))
-
-		assert.NotZero(t, file.Overflow)
-		overflowInfo := testutils.GetFileInfo(t, file.Overflow.Name())
-		assert.NotZero(t, overflowInfo.Size())
 	})
 
 	t.Run("for directories", func(t *testing.T) {

pool/file.go

@@ -3,6 +3,7 @@ package pool
 import (
 	"archive/zip"
 	"bytes"
+	"io"
 	"io/fs"
 	"os"
 	"path/filepath"
@@ -12,12 +13,17 @@ import (
 
 const defaultBufferSize = 1000000
 
+type Overflow interface {
+	io.ReadWriteSeeker
+	io.Closer
+}
+
 type File struct {
 	Path           string
 	Info           fs.FileInfo
 	CompressedData bytes.Buffer
 	Header         *zip.FileHeader
-	Overflow       *os.File
+	Overflow       Overflow
 	written        int64
 }