Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include HealthCheck in server pkg #44

Merged
merged 7 commits into from
Dec 2, 2021
Merged

feat: Include HealthCheck in server pkg #44

merged 7 commits into from
Dec 2, 2021

Conversation

wsalles
Copy link
Contributor

@wsalles wsalles commented Dec 1, 2021 •
edited by jira bot
Loading

Closes PLT-56

@wsalles wsalles added the feature A new feature label Dec 1, 2021
@wsalles wsalles self-assigned this Dec 1, 2021
renatoaguimaraes
renatoaguimaraes approved these changes Dec 1, 2021
View reviewed changes
pkg/common/server/server.go Outdated Show resolved Hide resolved
renatoaguimaraes
renatoaguimaraes suggested changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@renatoaguimaraes renatoaguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's think about readyz and healthz

portellaa
portellaa reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do something as AddHealthz and AddReadyz this could be enabled by the user if he wants.
I can see we needing this all the time, but i think it doesn't hurt to have this configurable

pkg/common/server/middlewares.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Dec 2, 2021
View reviewed changes
Copy link
Member

@portellaa portellaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mixed feelings about the names for AddHealthz and AddReadyz 🤔
perhaps something different, what do you think @renatoaguimaraes @wsalles ?

pkg/common/server/server.go Outdated Show resolved Hide resolved
pkg/common/server/server.go Outdated Show resolved Hide resolved
portellaa
portellaa reviewed Dec 2, 2021
View reviewed changes
pkg/common/helpers/utils.go Outdated Show resolved Hide resolved
pkg/common/helpers/utils.go Outdated Show resolved Hide resolved
pkg/common/helpers/utils.go Outdated Show resolved Hide resolved
@wsalles wsalles merged commit 6d51ed6 into master Dec 2, 2021
@wsalles wsalles deleted the feat/healthcheck-route branch December 2, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatoaguimaraes renatoaguimaraes renatoaguimaraes approved these changes

@portellaa portellaa portellaa approved these changes

Assignees

@wsalles wsalles

Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsalles @portellaa @renatoaguimaraes