feat(engine): prettier prints in report method #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsantos-ds
added
refactor
jfsantos-ds
commented
Sep 17, 2021
src/ydata_quality/core/warnings.py
Outdated
| @@ -33,6 +33,19 @@ def __str__(self): | |||
| return f"Priority {self.value}: {_descriptions[self.value]}" | |||
|
|
|||
|
|
|||
| class WarningStyling: | |||
| PRIORITIES = { | |||
There was a problem hiding this comment.
These are the colorcodes for the priority levels.
jfsantos-ds
commented
Sep 17, 2021
| @@ -107,14 +107,16 @@ def report(self): | |||
| "Prints a report containing all the warnings detected during the data quality analysis." | |||
| self.__clean_warnings() | |||
| if not self._warnings: | |||
| print('No warnings found.') | |||
| print(f'{WarningStyling.OKAY}No warnings found.{WarningStyling.ENDC}') | |||
There was a problem hiding this comment.
This small rework mimics the proposed structure in warnings pretty print task (notion)
|
The new version is leaner (I personally prefer it over the first one). |
UrbanoFonseca
suggested changes
Sep 20, 2021
UrbanoFonseca
approved these changes
Sep 22, 2021
UrbanoFonseca
force-pushed
the
feat/pretty_prints
branch
from
fe40039 to
e5c71d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added WarningStyle class with ANSI a series of relevant font customization codes:
Reworked the report method, making it leaner and better structured, for engines and DataQuality.