Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Fabric Regular Synthesizer to Streamlit app #252

Merged
merged 6 commits into from
Mar 22, 2023
Merged

Conversation

aquemy
Copy link
Contributor

@aquemy aquemy commented Mar 21, 2023

Add Fabric Regular Synthesizer to Streamlit app:

When Fabric Regular Synthesizer is selected, the input SDK Token is displayed and validated on the fly. If there is no token or the token is invalid, the following error and guidance is displayed:
image

When a particular path is specified for a model, we check in real time if it is a local model or from the SDK. If it is from the SDK, we display the token field and automatically fill it with the value serialized during training:
image

As the token might become invalid in between, we allow the user to change it. If the token is present with the model file but invalid, we display it as well:
image

@fabclmnt
Copy link
Contributor

fabclmnt commented Mar 22, 2023

@aquemy approved 🚀 ! Nevertheless, I have a few small requests:

  • Rename the model to ydata-sdk Synthesizer. Depending on the data type selected before, it will be the Regular of the Time-Series that will be available.

  • Can we please add the details on ydata-sdk to the Streamlit app About.py file under the current architectures that are supported so the users can access the docs and understand the new model origin.

@aquemy aquemy merged commit dcdab7f into dev Mar 22, 2023
@aquemy aquemy deleted the feat/SD-772 branch March 22, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants