feat: process relative path in balancer

Author: artemmufazalov

src/containers/Clusters/columns.tsx

@@ -10,7 +10,7 @@ import {UserCard} from '../../components/User/User';
 import type {PreparedCluster} from '../../store/reducers/clusters/types';
 import {formatStorageValuesToTb} from '../../utils/dataFormatters/dataFormatters';
 import {createDeveloperUIMonitoringPageHref} from '../../utils/developerUI/developerUI';
-import {getCleanBalancerValue, removeViewerPathname} from '../../utils/parseBalancer';
+import {getCleanBalancerValue} from '../../utils/parseBalancer';
 import {clusterTabsIds, getClusterPath} from '../Cluster/utils';
 
 import {COLUMNS_NAMES, COLUMNS_TITLES} from './constants';
@@ -27,9 +27,11 @@ export const CLUSTERS_COLUMNS: Column<PreparedCluster>[] = [
         header: COLUMNS_TITLES[COLUMNS_NAMES.TITLE],
         width: 230,
         render: ({row}) => {
-            const {balancer, name: clusterName, use_embedded_ui: useEmbeddedUi} = row;
-
-            const backend = balancer && removeViewerPathname(balancer);
+            const {
+                name: clusterName,
+                use_embedded_ui: useEmbeddedUi,
+                preparedBackend: backend,
+            } = row;
 
             const clusterPath =
                 useEmbeddedUi && backend
@@ -81,7 +83,12 @@ export const CLUSTERS_COLUMNS: Column<PreparedCluster>[] = [
             return versions[0] || undefined;
         },
         render: ({row}) => {
-            const {preparedVersions, versions = [], balancer, name: clusterName} = row;
+            const {
+                preparedVersions,
+                versions = [],
+                name: clusterName,
+                preparedBackend: backend,
+            } = row;
 
             const hasErrors = !versions.length || versions.some((item) => !item.version);
 
@@ -99,8 +106,6 @@ export const CLUSTERS_COLUMNS: Column<PreparedCluster>[] = [
                 };
             });
 
-            const backend = balancer && removeViewerPathname(balancer);
-
             return (
                 preparedVersions.length > 0 && (
                     <ExternalLink

src/store/reducers/clusters/types.ts

@@ -3,6 +3,7 @@ import type {ExtendedMetaClusterVersion} from '../../../utils/clusterVersionColo
 
 export interface PreparedCluster extends MetaExtendedClusterInfo {
     preparedVersions: ExtendedMetaClusterVersion[];
+    preparedBackend?: string;
 }
 
 export interface ClusterDataAggregation {

src/store/reducers/clusters/utils.ts

@@ -4,6 +4,7 @@ import {
     getVersionMap,
     prepareClusterVersions,
 } from '../../../utils/clusterVersionColors';
+import {prepareBackendFromBalancer} from '../../../utils/parseBalancer';
 
 import type {PreparedCluster} from './types';
 
@@ -24,5 +25,8 @@ export const prepareClustersData = (data: MetaClusters): PreparedCluster[] => {
     return clusters.map((cluster) => ({
         ...cluster,
         preparedVersions: prepareClusterVersions(cluster.versions, versionToColor),
+        preparedBackend: cluster.balancer
+            ? prepareBackendFromBalancer(cluster.balancer)
+            : undefined,
     }));
 };

src/utils/__test__/parseBalancer.test.ts

@@ -1,6 +1,7 @@
 import {
     getCleanBalancerValue,
     parseBalancer,
+    prepareBackendFromBalancer,
     removePort,
     removeProtocol,
     removeViewerPathname,
@@ -68,12 +69,17 @@ describe('removeViewerPathname', () => {
     });
 });
 describe('removeProtocol', () => {
-    test('should remove protocol', () => {
+    test('should remove protocol from start', () => {
         const initialValue = 'https://ydb-testing-0000.search.net:8765/viewer/json';
         const result = 'ydb-testing-0000.search.net:8765/viewer/json';
 
         expect(removeProtocol(initialValue)).toBe(result);
     });
+    test('should not remove protocol string in the middle', () => {
+        const initialValue = 'proxy/host/https:ydb-testing-0000.search.net';
+
+        expect(removeProtocol(initialValue)).toBe(initialValue);
+    });
 });
 describe('removePort', () => {
     test('should remove port', () => {
@@ -92,3 +98,69 @@ describe('getCleanBalancerValue', () => {
         expect(getCleanBalancerValue(initialValue)).toBe(result);
     });
 });
+describe('prepareBackendFromBalancer', () => {
+    const windowSpy = jest.spyOn(window, 'window', 'get');
+
+    afterEach(() => {
+        windowSpy.mockClear();
+    });
+    afterAll(() => {
+        windowSpy.mockRestore();
+    });
+
+    test('should not change full balancer value - only remove viewer pathname', () => {
+        const initialValue = 'https://ydb-testing-0000.search.net:8765/viewer/json';
+        const result = 'https://ydb-testing-0000.search.net:8765';
+
+        expect(prepareBackendFromBalancer(initialValue)).toBe(result);
+    });
+
+    test('should add meta backend for relative balancer value', () => {
+        const initialValue = '/proxy/host/ydb-testing-0000.search.net/viewer/json';
+        const result = 'https://my-host.ru/proxy/host/ydb-testing-0000.search.net';
+
+        windowSpy.mockImplementation(() => {
+            return {
+                meta_backend: 'https://my-host.ru',
+            } as Window & typeof globalThis;
+        });
+
+        expect(prepareBackendFromBalancer(initialValue)).toBe(result);
+    });
+    test('should add relative meta backend for relative balancer value', () => {
+        const initialValue = '/proxy/host/ydb-testing-0000.search.net/viewer/json';
+        const result = '/meta/proxy/host/ydb-testing-0000.search.net';
+
+        windowSpy.mockImplementation(() => {
+            return {
+                meta_backend: '/meta',
+            } as Window & typeof globalThis;
+        });
+
+        expect(prepareBackendFromBalancer(initialValue)).toBe(result);
+    });
+    test('should not add empty meta backend for relative balancer value', () => {
+        const initialValue = '/proxy/host/ydb-testing-0000.search.net/viewer/json';
+        const result = '/proxy/host/ydb-testing-0000.search.net';
+
+        windowSpy.mockImplementation(() => {
+            return {
+                meta_backend: '',
+            } as Window & typeof globalThis;
+        });
+
+        expect(prepareBackendFromBalancer(initialValue)).toBe(result);
+    });
+    test('should not add undefined meta backend for relative balancer value', () => {
+        const initialValue = '/proxy/host/ydb-testing-0000.search.net/viewer/json';
+        const result = '/proxy/host/ydb-testing-0000.search.net';
+
+        windowSpy.mockImplementation(() => {
+            return {
+                meta_backend: undefined,
+            } as Window & typeof globalThis;
+        });
+
+        expect(prepareBackendFromBalancer(initialValue)).toBe(result);
+    });
+});

src/utils/__test__/prepareBackend.test.ts

@@ -1,7 +1,7 @@
 import {getBackendFromNodeHost, getBackendFromRawNodeData, prepareHost} from '../prepareBackend';
 
 describe('prepareHost', () => {
-    test('should add vm prefix to cloud din nodes', () => {
+    test('should add u- prefix to cloud din nodes', () => {
         const cloudDinNodeInitialHost =
             'vm-cc8mco0j0snqehgh7r2a-ru-central1-c-nlmw-aniq.cc8mco0j0snqehgh7r2a.ydb.mdb.cloud-preprod.net';
         const cloudDinNodeResultHost =

src/utils/parseBalancer.ts

@@ -1,8 +1,11 @@
+const protocolRegex = /^http[s]?:\/\//;
+const viewerPathnameRegex = /\/viewer\/json$/;
+
 export const removeViewerPathname = (value: string) => {
-    return value.replace(/\/viewer\/json/, '');
+    return value.replace(viewerPathnameRegex, '');
 };
 export const removeProtocol = (value: string) => {
-    return value.replace(/http[s]?:\/\//, '');
+    return value.replace(protocolRegex, '');
 };
 
 export const removePort = (value: string) => {
@@ -47,3 +50,21 @@ export const parseBalancer = (rawBalancer: string): ParsedBalancer => {
 export const getCleanBalancerValue = (rawBalancer: string) => {
     return removePort(parseBalancer(rawBalancer).balancer);
 };
+
+export function prepareBackendFromBalancer(rawBalancer: string) {
+    const preparedBalancer = removeViewerPathname(rawBalancer);
+
+    // Test if balancer starts with protocol
+    // It means it full url and it can be used as it is
+    // Otherwise it is a relative path to the current meta backend
+    if (protocolRegex.test(rawBalancer)) {
+        return preparedBalancer;
+    }
+
+    // Use meta_backend if it is defined to form backend url
+    if (window.meta_backend) {
+        return window.meta_backend + preparedBalancer;
+    }
+
+    return preparedBalancer;
+}