feat: redesign query #1974
Open
feat: redesign query #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- src/components/ElapsedTime/ElapsedTime.scss: Language not supported
- src/components/QueryExecutionStatus/QueryExecutionStatus.scss: Language not supported
- src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.scss: Language not supported
- src/containers/Tenant/Query/QueryDuration/QueryDuration.scss: Language not supported
- src/containers/Tenant/Query/QueryEditorControls/EditorButton.scss: Language not supported
- src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/QueryResultError/QueryResultError.scss: Language not supported
- src/containers/Tenant/Query/QueryResult/components/ResultSetsViewer/ResultSetsViewer.scss: Language not supported
- src/components/ElapsedTime/ElapsedTime.tsx: Evaluated as low risk
- src/containers/Tenant/Query/CancelQueryButton/CancelQueryButton.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryDuration/QueryDuration.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx: Evaluated as low risk
- src/components/QueryExecutionStatus/QueryExecutionStatus.tsx: Evaluated as low risk
- src/containers/Tenant/Query/QueryResult/QueryResultViewer.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:63
- Add a null check for cancelQueryResponse before calling the reset method to avoid potential runtime errors.
cancelQueryResponse.reset();
src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx:104
- [nitpick] Ensure that the renderStopButton function is not called redundantly to improve code efficiency.
const renderStopButton = () => (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1949
CI Results
Test Status: ❌ FAILED
📊 Full Report
😟 No changes in tests. 😕
Bundle Size: ✅
Current: 80.61 MB | Main: 80.61 MB
Diff: +1.32 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information