Skip to content

Commit bdd8f81

Browse files
author
--list
committed
Change list of checkResult's arg in arrow_ut.cpp
1 parent 7bee2dc commit bdd8f81

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

ydb/library/yql/parser/pg_wrapper/ut/arrow_ut.cpp

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,9 @@ extern "C" {
1313
namespace {
1414

1515
template <bool IsFixedSizeReader>
16-
void checkResult(const char ** expected, auto result, NYql::NUdf::IBlockReader* reader) {
16+
void checkResult(const char ** expected, auto result, NYql::NUdf::IBlockReader* reader, auto out_fun) {
1717
const auto& data = result->data();
1818

19-
Datum (*out_fun)(PG_FUNCTION_ARGS);
20-
if constexpr (IsFixedSizeReader) {
21-
out_fun = date_out;
22-
} else {
23-
out_fun = numeric_out;
24-
}
25-
2619
for (int i = 0; i < data->length; i++) {
2720
if (result->IsNull(i)) {
2821
UNIT_ASSERT(expected[i] == nullptr);
@@ -89,7 +82,7 @@ Y_UNIT_TEST(PgConvertNumericDouble) {
8982
};
9083

9184
NYql::NUdf::TStringBlockReader<arrow::BinaryType, true> reader;
92-
checkResult<false>(expected, result, &reader);
85+
checkResult<false>(expected, result, &reader, numeric_out);
9386
}
9487

9588
Y_UNIT_TEST(PgConvertNumericInt) {
@@ -113,7 +106,7 @@ Y_UNIT_TEST(PgConvertNumericInt) {
113106
};
114107

115108
NYql::NUdf::TStringBlockReader<arrow::BinaryType, true> reader;
116-
checkResult<false>(expected, result, &reader);
109+
checkResult<false>(expected, result, &reader, numeric_out);
117110
}
118111

119112
Y_UNIT_TEST(PgConvertDate32Date) {
@@ -143,7 +136,7 @@ Y_UNIT_TEST(PgConvertDate32Date) {
143136
};
144137

145138
NUdf::TFixedSizeBlockReader<ui64, true> reader;
146-
checkResult<true>(expected, result, &reader);
139+
checkResult<true>(expected, result, &reader, date_out);
147140
}
148141

149142
} // Y_UNIT_TEST_SUITE(TArrowUtilsTests)

0 commit comments

Comments
 (0)