serial type must be not null

gridnevvvit · gridnevvvit · commit cc7f55bf9a1d · 2024-03-18T18:10:22.000+03:00
diff --git a/ydb/core/kqp/provider/yql_kikimr_type_ann.cpp b/ydb/core/kqp/provider/yql_kikimr_type_ann.cpp
@@ -887,6 +887,7 @@ virtual TStatus HandleCreateTable(TKiCreateTable create, TExprContext& ctx) over
 
                         columnMeta.DefaultFromSequence = "_serial_column_" + columnMeta.Name;
                         columnMeta.SetDefaultFromSequence();
+                        columnMeta.NotNull = true;
                     } else if (constraint.Name().Value() == "not_null") {
                         columnMeta.NotNull = true;
                     }
diff --git a/ydb/core/kqp/ut/scheme/kqp_constraints_ut.cpp b/ydb/core/kqp/ut/scheme/kqp_constraints_ut.cpp
@@ -256,7 +256,7 @@ Y_UNIT_TEST_SUITE(KqpConstraints) {
                                        result.GetIssues().ToString());
             CompareYson(R"(
                     [
-                        [[1];["New"]]
+                        [1;["New"]]
                     ]
                 )",
                 NYdb::FormatResultSetYson(result.GetResultSet(0)));

Original file line number	Diff line number	Diff line change
`@@ -887,6 +887,7 @@ virtual TStatus HandleCreateTable(TKiCreateTable create, TExprContext& ctx) over`
`887`	`887`
`888`	`888`	`columnMeta.DefaultFromSequence = "_serial_column_" + columnMeta.Name;`
`889`	`889`	`columnMeta.SetDefaultFromSequence();`
	`890`	`+ columnMeta.NotNull = true;`
`890`	`891`	`} else if (constraint.Name().Value() == "not_null") {`
`891`	`892`	`columnMeta.NotNull = true;`
`892`	`893`	`}`
Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ Y_UNIT_TEST_SUITE(KqpConstraints) {`
`256`	`256`	`result.GetIssues().ToString());`
`257`	`257`	`CompareYson(R"(`
`258`	`258`	`[`
`259`		`- [[1];["New"]]`
	`259`	`+ [1;["New"]]`
`260`	`260`	`]`
`261`	`261`	`)",`
`262`	`262`	`NYdb::FormatResultSetYson(result.GetResultSet(0)));`