Skip to content

Commit e33cb20

Browse files
committed
get rid of mkql results in scripting (#9997)
1 parent 24eb06b commit e33cb20

File tree

3 files changed

+1
-15
lines changed

3 files changed

+1
-15
lines changed

ydb/core/kqp/common/kqp_event_impl.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,14 +90,7 @@ void TEvKqp::TEvQueryRequest::PrepareRemote() const {
9090
Record.MutableRequest()->SetPoolId(PoolId);
9191
}
9292

93-
<<<<<<< HEAD
94-
=======
95-
if (!DatabaseId.empty()) {
96-
Record.MutableRequest()->SetDatabaseId(DatabaseId);
97-
}
98-
9993
Record.MutableRequest()->SetUsePublicResponseDataFormat(true);
100-
>>>>>>> a491b73df3 (get rid of mkql results in scripting (#9997))
10194
Record.MutableRequest()->SetSessionId(SessionId);
10295
Record.MutableRequest()->SetAction(QueryAction);
10396
Record.MutableRequest()->SetType(QueryType);

ydb/core/kqp/provider/yql_kikimr_gateway.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -858,7 +858,6 @@ class IKikimrGateway : public TThrRefBase {
858858
TString SessionId;
859859
TVector<Ydb::ResultSet*> Results;
860860
TMaybe<NKikimrKqp::TQueryProfile> Profile; // TODO: Deprecate.
861-
a491b73df3 (get rid of mkql results in scripting (#9997))
862861
NKqpProto::TKqpStatsQuery QueryStats;
863862
std::unique_ptr<NKikimrKqp::TPreparedQuery> PreparingQuery;
864863
std::shared_ptr<const NKikimrKqp::TPreparedQuery> PreparedQuery;

ydb/core/viewer/viewer_query.h

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -546,14 +546,8 @@ class TJsonQuery : public TViewerPipeClient {
546546
void MakeOkReply(NJson::TJsonValue& jsonResponse, NKikimrKqp::TEvQueryResponse& record) {
547547
const auto& response = record.GetResponse();
548548

549-
if (response.YdbResultsSize() > 0 || response.ResultsSize() > 0) {
549+
if (response.YdbResultsSize() > 0) {
550550
try {
551-
for (const auto& result : response.GetResults()) {
552-
Ydb::ResultSet resultSet;
553-
NKqp::ConvertKqpQueryResultToDbResult(result, &resultSet);
554-
ResultSets.emplace_back().emplace_back(std::move(resultSet));
555-
}
556-
557551
for (const auto& result : response.GetYdbResults()) {
558552
ResultSets.emplace_back().emplace_back(result);
559553
}

0 commit comments

Comments
 (0)