Drop coalesce crutch. (#1362)

Tony-Romanov · web-flow · commit f48a1ff716de · 2024-01-29T09:24:25.000+01:00
diff --git a/ydb/core/kqp/opt/physical/kqp_opt_phy_olap_filter.cpp b/ydb/core/kqp/opt/physical/kqp_opt_phy_olap_filter.cpp
@@ -503,10 +503,8 @@ TMaybeNode<TExprBase> SafeCastPredicatePushdown(const TCoFlatMap& inputFlatmap,
 TMaybeNode<TExprBase> CoalescePushdown(const TCoCoalesce& coalesce, TExprContext& ctx, TPositionHandle pos)
 {
     if constexpr (NSsa::RuntimeVersion >= 4U) {
-        if (!FindNode(coalesce.Ptr(), [](const TExprNode::TPtr& node) { return TCoJsonValue::Match(node.Get()); })) {
-            if (const auto node = YqlCoalescePushdown(coalesce, ctx)) {
-                return node;
-            }
+        if (const auto node = YqlCoalescePushdown(coalesce, ctx)) {
+            return node;
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -503,10 +503,8 @@ TMaybeNode<TExprBase> SafeCastPredicatePushdown(const TCoFlatMap& inputFlatmap,`
`503`	`503`	`TMaybeNode<TExprBase> CoalescePushdown(const TCoCoalesce& coalesce, TExprContext& ctx, TPositionHandle pos)`
`504`	`504`	`{`
`505`	`505`	`if constexpr (NSsa::RuntimeVersion >= 4U) {`
`506`		`- if (!FindNode(coalesce.Ptr(), [](const TExprNode::TPtr& node) { return TCoJsonValue::Match(node.Get()); })) {`
`507`		`- if (const auto node = YqlCoalescePushdown(coalesce, ctx)) {`
`508`		`- return node;`
`509`		`- }`
	`506`	`+ if (const auto node = YqlCoalescePushdown(coalesce, ctx)) {`
	`507`	`+ return node;`
`510`	`508`	`}`
`511`	`509`	`}`
`512`	`510`