BkReuseTest.java:46-49: Implement missing BkReuse.accept method to...

[davvd]

Puzzle 306-0f8af5fd in src/test/java/org/takes/http/BkReuseTest.java:46-49 has to be resolved: Implement missing BkReuse.accept method to support HTTP persistent connections and to pass below three tests. BkReuse.accept should handles more than one HTTP requests in one connection and return correct HTTP status when Content-Length is not specified.... The puzzle was created by Piotr Pradzynski on 22-Oct-2015.

If you have any technical questions, don't ask me, submit new tickets instead

[davvd]

@yegor256 attached this issue to milestone "1.0" (let me know if this is wrong)

[davvd]

@prondzyn the task is yours, please go ahead

[prondzyn]

@davvd please find someone else. Thanks.

[davvd]

@davvd please find someone else. Thanks.

@prondzyn -30 points to your rating

[davvd]

@davvd please find someone else. Thanks.

@prondzyn got it, someone else will be assigned soon

[davvd]

@HDouss it's yours now, please proceed keeping in mind our principles. Feel free to ask any technical questions right here in the ticket

The budget of this task is 30 mins. This is exactly how much time will be compensated, when the task is completed. Read about our Definition of Done

[HDouss]

@davvd : I am a little confused about the test methods. I don't see (or I don't understand) the relation between the socket and the (mocked) container. I was expecting the unit test plays client role, and BkReuse plays server role. I may be wrong but the container seems playing server role, and made to reply with an answer I expected to be the client request.

[HDouss]

@davvd : I think last commit #417 - improving tests to use jcabi http ce74f15 is not Ok. Should I open an issue for rewriting unit test ?

[HDouss]

@davvd I don't know if it is a requirement that BkReuse should decorate another Back.
Before delegating the process of the socket to the underlying Back, BkReuse should definitely read from the socket input stream and process some of the headers.
There is no way to reposition the socket input stream to be (correctly) processed again by the underlying Back.

[davvd]

@davvd : I am a little confused about the test methods. I don't see (or I don't understand) the relation between the socket and the (mocked) container. I was expecting the unit test plays client role, and BkReuse plays server role. I may be wrong but the container seems playing server role, and made to reply with an answer I expected to be the client request.

@HDouss check this out: http://www.yegor256.com/2015/02/16/it-is-not-a-school.html

[davvd]

@davvd : I think last commit #417 - improving tests to use jcabi http ce74f15 is not Ok. Should I open an issue for rewriting unit test ?

@HDouss address technical questions to the author of the ticket

[HDouss]

@davvd My two comments are related. I will ask the question on #417.

[davvd]

@davvd My two comments are related. I will ask the question on #417.

@HDouss OK, sure

[HDouss]

@davvd I ask more time as I am waiting for an answer on #417 and an answer on :

@davvd I don't know if it is a requirement that BkReuse should decorate another Back.
Before delegating the process of the socket to the underlying Back, BkReuse should definitely read from the socket input stream and process some of the headers.
There is no way to reposition the socket input stream to be (correctly) processed again by the underlying Back.

[davvd]

@HDouss the ticket is with you for 15 days already. If it is not finished in the next 48 hours, it will be re-assigned to someone else, see No Obligations principle, this article should help if you're stuck... as a reminder, don't forget to remove the @todo puzzle from the source code... -30 added to your rating, current score is: +0

[HDouss]

@davvd please note my last comment. I asked for more time, I think a redesign is required and I am waiting for replies.

[davvd]

@davvd please note my last comment. I asked for more time, I think a redesign is required and I am waiting for replies.

@HDouss sure, thanks for telling me, take your time

[HDouss]

@davvd please revoke my rating and answer my redesign question.

[yegor256]

@HDouss please, check these two articles: http://www.yegor256.com/2015/02/16/it-is-not-a-school.html and http://www.yegor256.com/2015/01/15/how-to-cut-corners.html Basically, if something is not clear it's either your problem and you should solve it on your own, or it's a problem of the project and you should report it. Nobody will help you here.

[HDouss]

@davvd I can't continue until #456 is resolved.

[davvd]

@davvd I can't continue until #456 is resolved.

@HDouss yes, right, let's wait for #456

[davvd]

@yegor256 #456 is closed, it was an impediment

[HDouss]

@davvd I am still waiting for #454 here.

[davvd]

@davvd I am still waiting for #454 here.

@HDouss agreed, we'll wait for #454

[davvd]

@yegor256 The issue is closed

[davvd]

@ypshenychka please, let us know what do you think about this ticket, according to our QA rules

[HDouss]

@davvd This issue is not resolved yet. The puzzle description have just moved from BkReuseTest to BkBasicTest because BkReuseTest is deleted and we get rid of it. But the issue is still unresolved.

[HDouss]

@davvd The puzzle here is the same as in #519. It was just moved. I worked on this issue for a long time, so why closing it and open another (same) one ?

[HDouss]

@yegor256 Could you please help here ?

[HDouss]

@davvd Ping

@davvd The puzzle here is the same as in #519. It was just moved. I worked on this issue for a long time, so why closing it and open another (same) one ?

[yegor256]

@HDouss it looks like the puzzle is gone and a new one showed up. you can check PUZZLES.md file in the root directory for a full list of puzzles currently active. yours is there?

[HDouss]

@yegor256 It is gone because BkReuseTest class was removed, but the issue is still here.

[yegor256]

@HDouss so, this issue will be fixed in a new ticket. we work with micro-tasks, remember that. we can't solve all together in one ticket. if the puzzle is gone, the problem is gone. period.

[HDouss]

@yegor256 This puzzle is not gone. he has just "moved" (and somehow reformulated) from BkReuseTest to BkBasicTest.

[yegor256]

@HDouss that's the thing - if it's "reformulated", it's a different puzzle. our puzzle detecting software can't understand whether it's the same problem or a different one. it only checks the text.

[HDouss]

@yegor256 Ok. Let's forget about it.

[ypshenychka]

@HDouss So will there be a related fix in scope of this ticket?

[HDouss]

@ypshenychka No, I don't think it has any sens.

[ypshenychka]

@HDouss got it. Thanks.

[ypshenychka]

@davvd Quality is bad here.

[davvd]

@davvd Quality is bad here.

@ypshenychka thank you for paying attention

[davvd]

@HDouss 10 mins was added to the account of @ypshenychka (for QA review), in transaction 75134863