Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BkBasicTest.java:69-71: Move header names from BkBasic... #534

Closed
davvd opened this issue Jan 22, 2016 · 8 comments
Closed

BkBasicTest.java:69-71: Move header names from BkBasic... #534

davvd opened this issue Jan 22, 2016 · 8 comments
Milestone

Comments

@davvd
Copy link

davvd commented Jan 22, 2016

Puzzle 516-ffc97ad1 in src/test/java/org/takes/http/BkBasicTest.java:69-71 has to be resolved: Move header names from BkBasic to public constants. Reusable header names will help in many situations. For example - in new integration tests.... The puzzle was created by lexx on 21-Jan-2016.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code.

@davvd
Copy link
Author

davvd commented Jan 22, 2016

@danff the task is yours,please go ahead

@davvd
Copy link
Author

davvd commented Jan 22, 2016

@yegor256 I added milestone 1.0 to this issue, let me know if there has to be something else

@ghost
Copy link

ghost commented Jan 22, 2016

@davvd PR #537 for this issue created.

@davvd
Copy link
Author

davvd commented Jan 23, 2016

@davvd PR #537 for this issue created.

@danff thanks

@ghost
Copy link

ghost commented Feb 5, 2016

@davvd need more time here - waiting for the PR resolution

@davvd
Copy link
Author

davvd commented Feb 6, 2016

@davvd need more time here - waiting for the PR resolution

@danff sure, thanks for telling me, take your time

@davvd
Copy link
Author

davvd commented Dec 21, 2016

@yegor256 The task is closed, thanks everybody

@davvd davvd closed this as completed Dec 21, 2016
@davvd
Copy link
Author

davvd commented Dec 21, 2016

@elenavolokhova please, help us to evaluate quality here, as per par.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant