Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

HTML Minification - Ignoring {{route}} #95

Closed
element824 opened this issue Nov 17, 2014 · 3 comments
Closed

HTML Minification - Ignoring {{route}} #95

element824 opened this issue Nov 17, 2014 · 3 comments

Comments

@element824
Copy link

Hi,
I found an issue while deploying the project using grunt build.
There was a problem with "minifyHtml" task.
This task is ignoring the {{route}} value in the selected attribute of a polymer core element..
I had to comment this task (grunt file) to make it work.

In Detail.
I have a core animated pages with selected attributed set as {{route}}
" core-animated-pages valueattr="hash" selected="{{route}}"

When deploying this using grunt build, the distributed file has only the following.
core-animated-pages valueattr="hash" selected

This is missing the selected attribute value.
This is happening not only for core animated pages, but also for for core menu.

Thanks
Koushik

@robdodson
Copy link
Contributor

It looks like the issue is caused by the selected attribute itself. If you use a different attribute name, like baz, minifyHtml will leave the binding in place.

@sindresorhus any idea how to fix this?

@robdodson robdodson added the bug label Dec 12, 2014
@sindresorhus
Copy link
Member

Swaagie/minimize#27

@robdodson robdodson added this to the 0.7.0, Gulping Goanna milestone Dec 17, 2014
@robdodson
Copy link
Contributor

75b4e96 fixes this by adding the spare: true option to the minifyHtml task. I subscribed to the thread linked by @sindresorhus to see if there are any future updates on this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants