Skip to content

Commit

Permalink
Changing the way Bootstrap Sass package is ref'd
Browse files Browse the repository at this point in the history
Aliasing "bootstrap-sass" to the github URL
git://github.com/twbs/bootstrap-sass.git is probably not a good idea.
This could create confusion with the bootstrap-sass package in
the official repository which actually points to
git://github.com/jlong/sass-twitter-bootstrap.git and only goes up to
version 3.0.2 currently. This is NOT the official package.

Changed references to "bootstrap-sass-official" to avoid any
potential confusion.
  • Loading branch information
CaptSaltyJack committed Mar 7, 2014
1 parent 548530e commit f69c119
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ AppGenerator.prototype.writeIndex = function writeIndex() {

// wire Bootstrap plugins
if (this.includeBootstrap) {
var bs = 'bower_components/bootstrap' + (this.includeCompass ? '-sass/vendor/assets/javascripts/bootstrap/' : '/js/');
var bs = 'bower_components/bootstrap' + (this.includeCompass ? '-sass-official/vendor/assets/javascripts/bootstrap/' : '/js/');
this.indexFile = this.appendScripts(this.indexFile, 'scripts/plugins.js', [
bs + 'affix.js',
bs + 'alert.js',
Expand Down
2 changes: 1 addition & 1 deletion app/templates/Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ module.exports = function (grunt) {
'images/{,*/}*.webp',
'{,*/}*.html',
'styles/fonts/{,*/}*.*'<% if (includeBootstrap) { %>,<% if (includeCompass) { %>
'bower_components/bootstrap-sass/vendor/assets/fonts/bootstrap/*.*'<% } else { %>
'bower_components/bootstrap-sass-official/vendor/assets/fonts/bootstrap/*.*'<% } else { %>
'bower_components/bootstrap/dist/fonts/*.*'<% } %><% } %>
]
}]
Expand Down
2 changes: 1 addition & 1 deletion app/templates/_bower.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "<%= _.slugify(appname) %>",
"private": true,
"dependencies": {<% if (includeBootstrap) { if (includeCompass) { %>
"bootstrap-sass": "twbs/bootstrap-sass#v3.1.0",<% } else { %>
"bootstrap-sass-official": "~3.1.0",<% } else { %>
"bootstrap": "~3.0.3",<% }} if (includeModernizr) { %>
"modernizr": "~2.6.2",<% } %>
"jquery": "~1.11.0"
Expand Down
4 changes: 2 additions & 2 deletions app/templates/main.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<% if (includeBootstrap) { %>$icon-font-path: "/bower_components/bootstrap-sass/vendor/assets/fonts/bootstrap/";
<% if (includeBootstrap) { %>$icon-font-path: "/bower_components/bootstrap-sass-official/vendor/assets/fonts/bootstrap/";

// bower:scss
@import 'bootstrap-sass/vendor/assets/stylesheets/bootstrap.scss';
@import 'bootstrap-sass-official/vendor/assets/stylesheets/bootstrap.scss';
// endbower

.browsehappy {
Expand Down

0 comments on commit f69c119

Please sign in to comment.