support self signed certificates

[maddanio]

Hello,

I need to use this wonderful plugin against a server of ours inside a vpn which has a self signed cert. so I would need to tell the plugin the cert or disable ssl checking, either one would be good for me, any hints how to do that?

Best

[yeraydiazdiaz]

Hi @maddanio, I'd rather not disable certificate validation if we can help it as it's generally a bad idea. But now that we have settings since 1.0.0 we could add an option for users to set options we can pass through to urllib3.

[maddanio]

Of course not by default, ideally per request explicitly. We just need it in a rather peculiar setup. Would be super great as it seems to be stupidly hard to find a tool for this that does not try to get you into some weird enterprise subscription. So are you saying i can do this right now?

[yeraydiazdiaz]

No, sorry, I was describing how it could be implemented.

[maddanio]

well, per query would be great, global would also be ok. i can also try my hands at a pr, but not sure I will find the time :(

[maddanio]

as a syntax I would suggest @@ as a prefix as additional urlopen arguments, or @urlopen.<keyword>. I can make a pr

[maddanio]

ah, I just noticed the argument for certificate validation is on the connection pool level. so I guess a setting would be better

[maddanio]

ok, I added it somehow, but the settings dont appear in the sublime settings list? also I am not sure if reload works

[maddanio]

#29

[maddanio]

aleternatively/additionally it might be better to allow additional certificates?