Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit sensitive fields from logging #1113

Closed
tomchop opened this issue Jul 23, 2024 · 1 comment
Closed

Omit sensitive fields from logging #1113

tomchop opened this issue Jul 23, 2024 · 1 comment
Labels
code health Changes about syntax, code health, etc. core python Pull requests that update Python code security-impact Changes that affect security and users should keep an eye on

Comments

@tomchop
Copy link
Collaborator

tomchop commented Jul 23, 2024

Some sensitive fields should be exempt from logging.

As seen in #1111, if we want to be precise, this requires a bit more thought than just parsing the JSON body of the request. Pydantic offers a potentially useful mechanism, https://docs.pydantic.dev/2.0/usage/types/secrets/.
@tomchop tomchop mentioned this issue Jul 23, 2024
Merged
@udgover udgover added code health Changes about syntax, code health, etc. python Pull requests that update Python code security-impact Changes that affect security and users should keep an eye on core labels Oct 28, 2024
@udgover
Copy link
Collaborator

udgover commented Oct 28, 2024

Fixed in #1151

@udgover udgover closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Changes about syntax, code health, etc. core python Pull requests that update Python code security-impact Changes that affect security and users should keep an eye on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@udgover @tomchop