Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default_tag_expiration from yeti.conf not used #1145

Closed
0xRet opened this issue Oct 10, 2024 · 2 comments
Closed

default_tag_expiration from yeti.conf not used #1145

0xRet opened this issue Oct 10, 2024 · 2 comments
Labels
code health Changes about syntax, code health, etc. core python Pull requests that update Python code

Comments

@0xRet
Copy link
Contributor

0xRet commented Oct 10, 2024

Description

In yeti.conf.sample we can find a default_tag_expiration variable.
This variable seems to not be used elsewhere.

Expected behavior

This variable should replace the default value DEFAULT_EXPIRATION specified in core/schemas/tag.py

Actual behavior

Only DEFAULT_EXPIRATION is used.
@mbonino
Copy link
Contributor

mbonino commented Oct 14, 2024

#1147 should fix the issue.

@mbonino mbonino mentioned this issue Oct 14, 2024
Merged
@udgover udgover added code health Changes about syntax, code health, etc. python Pull requests that update Python code core labels Oct 28, 2024
@udgover udgover closed this as completed Oct 28, 2024
@udgover
Copy link
Collaborator

udgover commented Oct 28, 2024

Fixed by #1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Changes about syntax, code health, etc. core python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@udgover @mbonino @0xRet