Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bincode support #413

Closed
artem-v-shamsutdinov opened this issue Oct 11, 2018 · 3 comments · Fixed by #806
Closed

Add bincode support #413

artem-v-shamsutdinov opened this issue Oct 11, 2018 · 3 comments · Fixed by #806
Labels
feature-request A feature request good first issue

Comments

@artem-v-shamsutdinov
Copy link

Description

I'm submitting a ... (check one with "x")

  • feature request

Put your description here

Right now CBOR is supported. Based on this comparison bincode looks to be much more efficient. Can you please also add support for bincode?

Thank you!
@artem-v-shamsutdinov artem-v-shamsutdinov changed the title Feature request: add bincode o Feature request: add bincode support Oct 11, 2018
@serzhiio
Copy link
Contributor

you can look at my fork untill its not merged, ive implemented Bincode()

@jstarry
Copy link
Member

jstarry commented Sep 27, 2019

@serzhiio can you open a PR for your bincode changes?

@jstarry jstarry changed the title Feature request: add bincode support Add bincode support Sep 27, 2019
@zaeleus
Copy link
Contributor

zaeleus commented Oct 18, 2019

@serzhiio Are you still working on this? If not, I can submit a patch.

@serzhiio serzhiio mentioned this issue Oct 19, 2019
Closed
@jstarry jstarry mentioned this issue Dec 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature request good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bincode format and make bincode an optional dependency jstarry/yew
4 participants
@zaeleus @jstarry @artem-v-shamsutdinov @serzhiio