Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTA linkType type definition does not match default streams type for this field. #43

Open
1 task done
Jared-Hood opened this issue Mar 15, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@Jared-Hood
Copy link
Contributor

Describe the bug

For the builtin Yext CTA field streams pulls in the cta.linkType field as PHONE or EMAIL by default (with no transform set). These values are defined in this library as Phone and Email, which does not match the streams value. This causes the getHref function to not correctly evaluate the href for an email or phone link.

Reproduction

No response

System Info

System:
    OS: macOS 13.5.1
    CPU: (12) x64 Apple M2 Max
    Memory: 1.77 GB / 64.00 GB
    Shell: 5.2.26 - /opt/homebrew/bin/bash
  Binaries:
    Node: 12.20.2 - ~/.nvm/versions/node/v12.20.2/bin/node
    Yarn: 1.22.21 - /opt/homebrew/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v12.20.2/bin/npm
  Browsers:
    Chrome: 122.0.6261.129
    Safari: 17.1
  npmPackages:
    @reach/auto-id: 0.18.0 => 0.18.0 
    @tailwindcss/nesting: 0.0.0-insiders.565cd3e => 0.0.0-insiders.565cd3e 
    @types/react: 17.0.40 => 17.0.40 
    @types/react-dom: 17.0.10 => 17.0.10 
    @typescript-eslint/eslint-plugin: 5.48.2 => 5.48.2 
    @typescript-eslint/parser: 5.48.2 => 5.48.2 
    @vitejs/plugin-react: 4.2.1 => 4.2.1 
    @yext/cobalt: 0.0.1 => 0.0.1 
    @yext/components-404: 2.1.0 => 2.1.0 
    @yext/custom-field-debugger: 2.0.9 => 2.0.9 
    @yext/eslint-config: 1.0.0 => 1.0.0 
    @yext/eslint-plugin-export-star: 1.1.0 => 1.1.0 
    @yext/pages: 1.0.0 => 1.0.0 
    @yext/pages-components: 1.0.0-rc.1 => 1.0.0-rc.2 
    @yext/schema-wrapper: 1.0.4 => 1.0.4 
    @yext/search-headless-react: 2.4.0 => 2.4.0 
    @yext/search-ui-react: 1.4.1 => 1.4.1 
    @yext/sites-react-components: 0.1.16 => 0.1.16 
    @yext/types: 0.1.10-alpha => 0.1.10-alpha 
    autoprefixer: 10.4.13 => 10.4.13 
    classnames: 2.3.1 => 2.3.1 
    eslint: 8.32.0 => 8.32.0 
    eslint-config-prettier: 8.6.0 => 8.6.0 
    eslint-plugin-react: 7.32.1 => 7.32.1 
    eslint-plugin-react-perf: 3.3.1 => 3.3.1 
    eslint-plugin-tsdoc: 0.2.17 => 0.2.17 
    generate-license-file: 2.0.0 => 2.0.0 
    husky: 8.0.0 => 8.0.0 
    i18next: 23.4.4 => 23.4.4 
    i18next-conv: 14.0.0 => 14.0.0 
    i18next-parser: 8.6.0 => 8.6.0 
    libphonenumber-js: 1.10.14 => 1.10.14 
    lodash: 4.17.21 => 4.17.21 
    plop: 3.1.1 => 3.1.1 
    postcss: ^8.4.12 => 8.4.35 
    postcss-mixins: 9.0.3 => 9.0.3 
    prettier: 2.6.2 => 2.6.2 
    pretty-quick: 3.1.3 => 3.1.3 
    react: 17.0.2 => 17.0.2 
    react-collapsed: 3.6.0 => 3.6.0 
    react-dom: 17.0.2 => 17.0.2 
    react-error-boundary: 4.0.8 => 4.0.8 
    react-markdown: 8.0.7 => 8.0.7 
    react-router-dom: 6.3.0 => 6.3.0 
    tailwind-merge: 1.3.0 => 1.3.0 
    tailwindcss: 3.3.2 => 3.3.2 
    typescript: 5.0.4 => 5.0.4 
    vite: 5.1.2 => 5.1.2

Used Package Manager

npm

Used Browser

Chrome

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@Jared-Hood Jared-Hood added the bug Something isn't working label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant