Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated metric name on chan expr #40

Closed
coanor opened this issue Aug 20, 2023 · 1 comment
Closed

Duplicated metric name on chan expr #40

coanor opened this issue Aug 20, 2023 · 1 comment

Comments

@coanor
Copy link
Contributor

coanor commented Aug 20, 2023

When create metric in the form:

MyMetric := p8s.NewDesc("my_name", "some help", []string{/* some labels */}, nil)

ch <- p8s.MustNewConstMetric(MyMetric, p8s.CounterValue, someFloat64, "label-1")
ch <- p8s.MustNewConstMetric(MyMetric, p8s.CounterValue, someFloat64, "label-2")

The list will output 2 metric, we should uniq the metric during list.

@yeya24
Copy link
Owner

yeya24 commented Apr 22, 2024

Closed by #39

@yeya24 yeya24 closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants