Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Stars #41

Closed
Ekhazeni opened this issue Dec 1, 2019 · 4 comments
Closed

Fixed Stars #41

Ekhazeni opened this issue Dec 1, 2019 · 4 comments
Assignees

Comments

@Ekhazeni
Copy link

Ekhazeni commented Dec 1, 2019

Hi Yan,
I faced some issues using fixed stars functions. I also downloaded the latest "sefstars.txt" but the result is the same.

1- The two new fixed star functions (swe_fixstar2_ut and swe_fixstar2) are not working at at all.
2- The old functions (swe_fixstar_ut and swe_fixstar) are not working properly.
in

Star=1          'Integer works However a string should be returned by Ref and Star is an integer so it fails
Star=10        

Star="1"        'Works up to 9 
Star="10"      'Doesn't Work
Star="Spica" 'Direct name works!
Star="alVir"  'Doesn't work!
Star=",alVir" 'Doesn't work! 

SWE_Chart.swe_fixstar(STAR, tjd_ut, fxflag, stararray, serr)   

As the original C++ code based on char*, using Sweph32.dll I was using type StringBuilder and it was working fine. Please take a look.

All the best,
Ehsan

@ygrenier ygrenier self-assigned this Dec 3, 2019
@ygrenier
Copy link
Owner

ygrenier commented Dec 3, 2019

Hi,

Thanks for the report. I'll look it asap.

@ygrenier ygrenier pinned this issue Dec 3, 2019
@ygrenier ygrenier unpinned this issue Dec 3, 2019
@Ekhazeni
Copy link
Author

Hi there,

Any progress?

Thank you :-)

@ygrenier
Copy link
Owner

Hi,

Sorry I'm working slowly because lot of jobs and familly constraints :)

I found small issues of the portage about the fixed star file parsing. I also detect more complex issues about the sort and the search of the fixed star.

I'm working to fix it asap.

Regards

@ygrenier
Copy link
Owner

Fixed : https://github.com/ygrenier/SwissEphNet/releases/tag/v2.8.0.2

The package is updated to Nuget gallery.

I created a test class Issue41Test for this work, normally I check all kind of search, but if you can verify this can help me :)

Thanks, regards

Yanos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants