Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics #7

Open
rosswintle opened this issue Aug 31, 2015 · 0 comments
Open

Google Analytics #7

rosswintle opened this issue Aug 31, 2015 · 0 comments

Comments

@rosswintle
Copy link

This is great! I'm tinkering with/learning Laravel and this is a nice little project to explore. There's a few things that I think should probably be moved off to the .env file, and some stuff missing from the README on how to get going (adding the app key for instance), but my main issue I'm raising here is that you have some of your own Google Analytics code in the index.blade.php view.

What would be nice would be to move the GA code off to a setting in .env.sample (and instruct people to copy this to .env) and then include the GA script in all the views.

Thanks though! Love this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant