-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart-sass #34
Comments
I think node-sass is fast enough and dart-sass is still under heavily development, so the answer is NO. |
One reason to allow dart-sass could be that it is supposedly properly supports CSS media query Level 4 syntax, which currently libsass does not. But I agree that the best would be to implement the feature in libsass. |
@yibn2008 Could you reconsider this decision? We're using One suggestion would be to let the consumer specify which compiler he wants to use: {
loader: 'fast-sass-loader',
options: {
sass: require('sass'),
sassOptions: require('fibers'),
},
}, Here is my fork that implements this proposition: ngryman@c876f42. We use it in production without any issue. Note that this fork defaults to use |
I second dart-sass option. Our main issue with node-sass is the binary nature of its dependencies, which are not practical in our enviroments. |
@yibn2008 Any second though about this?
Because of those reasons it would make sense for |
In addition, dart-sass is currently the only sass implementation including the new module system, which is a huge advance in sass. The sass project also states that dart-sass is the recommended and go-forward implementation. Right now one can use sass modules ( |
@ngryman I don't have any experience with dart-sass, but if you really want this feature support, please provider a PR. |
@yibn2008 Awesome, thanks for reconsidering! I'll open a PR based on my fork early January. |
^ For those interested I just opened a PR for that. |
LibSass is now officially deprecated |
Has there been any discussion of using sass/embedded-host-node over |
already supported dart-sass |
It's being discussed in sass-loader wondering if it's been considered here as ruby-sass is being deprecated soon.
webpack-contrib/sass-loader#435
The text was updated successfully, but these errors were encountered: