Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate a mechanism to check knitr PR on a branch of knitr-examples #76

Open
cderv opened this issue Jan 27, 2021 · 1 comment
Open

Comments

@cderv
Copy link
Collaborator

cderv commented Jan 27, 2021

This was previously possible but removed when Github actions was put in place.
#72

I think it could be easier when we add feature into knitr using PR to be able to add a knitr-examples at the time, and merge the PR when we know the knitr-examples check including the new examples will pass.

Currently this is not possible when using only master.

Could be done locally for our work though so opening this as a reminder to do when there are no other priorities

@cderv
Copy link
Collaborator Author

cderv commented Jan 27, 2021

Or we could use snapshot tests inside knitr directly but that would be considered if ever we switched to use testthat 3 inside knitr, or we develop a similar tooling in testit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant