Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot define an engine.path for dot engine #1534

Closed
billy34 opened this issue Apr 16, 2018 · 2 comments
Closed

cannot define an engine.path for dot engine #1534

billy34 opened this issue Apr 16, 2018 · 2 comments
Labels
bug Bugs
Milestone

Comments

@billy34
Copy link

billy34 commented Apr 16, 2018

It seems that defining an engine path for dot engine does not work as expected. In fact the value is not used at all.

Looking into the code I think I found the origin of the problem located in the eng_dot function of the engines.r file and especially in the following lines:

cmd = sprintf(command_string, shQuote(options$engine %n% options$engine.path),
shQuote(f), ext <- options$fig.ext %n% dev2ext(options$dev),
shQuote(paste0(fig <- fig_path(), '.', ext)))

As options$engine is always defined, options$engine.path has no chance to be used!

One way to correct code is simply swapping options$engine and options$engine.path or use the function get_engine_path(options$engine.path,options$engine) you use for other engines.

@yihui yihui added this to the v1.21 milestone Apr 16, 2018
@yihui yihui closed this as completed in 8eaa325 Apr 16, 2018
@yihui yihui added the bug Bugs label Apr 16, 2018
@yihui
Copy link
Owner

yihui commented Apr 16, 2018

Should be fixed now. Thanks for the report!

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs
Projects
None yet
Development

No branches or pull requests

2 participants