Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knitr and comments #239

Closed
jamiefolson opened this issue May 16, 2012 · 3 comments
Closed

knitr and comments #239

jamiefolson opened this issue May 16, 2012 · 3 comments
Labels
feature Feature requests
Milestone

Comments

@jamiefolson
Copy link

I would like to reopen the issue regarding knitr and comments. I don't quite understand either the technical or semantic/syntactic arguments against obeying latex comments: "%". I successfully modified knitr to obey source comments so that inside knitr commands, they're ignored, but outside knitr commands they're respected. I'd be happy to provide a patch for anyone to look over. I only wrote the regexp for latex comments, but it'd be easy (as long as you can describe comments with a regex) to extend it to any other source type.

I would see the reasoning against it except that \Sexpr{} and \SweaveOpts{} appear as if they were latex commands and it seems to me as if the expected thing is for them to obey comments.

@yihui
Copy link
Owner

yihui commented May 17, 2012

this feature is not there mainly because of implementation difficulties (as mentioned in #110), so if you have already succeeded in letting knitr obey LaTeX comments, I will be glad to accept the patch

@yihui
Copy link
Owner

yihui commented Jun 11, 2012

this has been done in #110, so I'm closing it

@yihui yihui closed this as completed Jun 11, 2012
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Feature requests
Projects
None yet
Development

No branches or pull requests

2 participants