Add alias in DQLQueryBuilder::selectExists() method for consistency (#326)

Author: Tigrov

CHANGELOG.md

@@ -46,6 +46,7 @@
 - New #316: Realize `Schema::loadResultColumn()` method (@Tigrov)
 - New #323: Use `DateTimeColumn` class for datetime column types (@Tigrov)
 - Enh #324: Refactor `Command::insertWithReturningPks()` method (@Tigrov)
+- Chg #326: Add alias in `DQLQueryBuilder::selectExists()` method for consistency with other DBMS (@Tigrov)
 
 ## 1.3.0 March 21, 2024
 

src/DQLQueryBuilder.php

@@ -57,7 +57,7 @@ public function buildOrderByAndLimit(
 
     public function selectExists(string $rawSql): string
     {
-        return 'SELECT CASE WHEN EXISTS(' . $rawSql . ') THEN 1 ELSE 0 END FROM DUAL';
+        return 'SELECT CASE WHEN EXISTS(' . $rawSql . ') THEN 1 ELSE 0 END AS "0" FROM DUAL';
     }
 
     public function buildFrom(array|null $tables, array &$params): string

tests/Provider/QueryBuilderProvider.php

@@ -119,17 +119,6 @@ public static function insert(): array
         return $insert;
     }
 
-    public static function selectExist(): array
-    {
-        $selectExist = parent::selectExist();
-
-        $selectExist[0][1] = <<<SQL
-        SELECT CASE WHEN EXISTS(SELECT 1 FROM `table` WHERE `id` = 1) THEN 1 ELSE 0 END FROM DUAL
-        SQL;
-
-        return $selectExist;
-    }
-
     public static function upsert(): array
     {
         $concreteData = [

tests/QueryBuilderTest.php

@@ -451,10 +451,16 @@ public function testResetSequenceCompositeException(): void
         $db->close();
     }
 
-    #[DataProviderExternal(QueryBuilderProvider::class, 'selectExist')]
-    public function testSelectExists(string $sql, string $expected): void
+    public function testSelectExists(): void
     {
-        parent::testSelectExists($sql, $expected);
+        $db = $this->getConnection();
+        $qb = $db->getQueryBuilder();
+
+        $sql = 'SELECT 1 FROM "customer" WHERE "id" = 1';
+        // Alias is not required in Oracle, but it is added for consistency with other DBMS.
+        $expected = 'SELECT CASE WHEN EXISTS(SELECT 1 FROM "customer" WHERE "id" = 1) THEN 1 ELSE 0 END AS "0" FROM DUAL';
+
+        $this->assertSame($expected, $qb->selectExists($sql));
     }
 
     #[DataProviderExternal(QueryBuilderProvider::class, 'update')]