Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse: If content is not an array, footer gets ignored #262

Open
Commifreak opened this issue Aug 24, 2021 · 1 comment
Open

Collapse: If content is not an array, footer gets ignored #262

Commifreak opened this issue Aug 24, 2021 · 1 comment
Labels
Milestone

Comments

@Commifreak
Copy link

Commifreak commented Aug 24, 2021

What steps will reproduce the problem?

Create a Collapse widget with non-array content and set footer

			$items[] = [
			        'label' =>      'Label',
			        'content' => 'Test',
                    'footer' => 'Footer'
			        ];

What's expected?

Display content as-is along with the specified footer

What do you get instead?

Footer only gets displayed, when content is an array: https://github.com/yiisoft/yii2-bootstrap/blob/master/src/Collapse.php#L227

Additional info

Q A
Yii-Bootstrap vesion 2.0.11
Yii vesion 2.0.43
PHP version 7.4
Operating system Linux
@Commifreak
Copy link
Author

The change came with: 599d60c - before that, footer seemed unsupported.

Maybe footer could be supported for both variants, regardles of content's type?

@yiisoft yiisoft deleted a comment from turn2media Aug 24, 2021
@samdark samdark added the type:bug Bug label Aug 24, 2021
@samdark samdark added this to the 2.0.11 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants