Preparing first stable release

[machour]

This extension seems almost ready and is already totaling ~20k downloads :)
We should probably publish a first stable release into the wild and see how it plays.

We still need to:

• Document some stuff: NavBar collapse button alignment #25, [docs] Improve "Compiling from the .sass files" #81, using bootstrap4 cdn on yii2-advanced template? #83
• Fix two layout problems: ActiveField not show validation error message with custom inputTemplate #36, ActiveField checkbox with horizontal layout #78
• Switch to npm: The file or directory to be published does not exist: ROOTvendor/bower-asset/bootstrap/assets/js/vendor #35 (PR Change Bower to NPM. #40)
• Change Bower to NPM & update composer.json. #85 update dependency versions

@simialbi do you have the time to look at the open issues? (no pressure)

[samdark]

Documentation issues left...

[samdark]

And #85

[samdark]

Also I think it worth taking a look at https://github.com/yiisoft/yii2-bootstrap/milestones/2.1

[machour]

Worth considering for first release as these would break BC later

• use bootstrap classes for errorSummaryCssClass yii2-bootstrap#57
• Fix: label in inline form not visible yii2-bootstrap#76

[samdark]

These can't be moved so the only way it to re-apply these to code in this repository.

[machour]

@simialbi interested on your take about the remaining items in the old 2.1 milestone: https://github.com/yiisoft/yii2-bootstrap/milestones/2.1

[simialbi]

There are still 4 items:

• NavBar class not easily extendable due to html in the init function yii2-bootstrap#164: I recommend not to realise this. The current class fulfills all the variants described by the documentation. In my opinion anything going further has to be customized by application, not library.
• Inconsistent naming: dropdown vs. dropDown yii2-bootstrap#147: Could be realised, but would break BC. As you already mentioned, there are already 20k installs...
• Navbar brandLabel custom html yii2-bootstrap#101: Could easily be realised but would change current behavior. For me it's ok. @samdark ? @machour ? What do you think ? (Code Reference: https://github.com/simialbi/yii2-bootstrap4/blob/69d8b7779f7983d1b5768110d0e7c58ba723a96c/src/NavBar.php#L139)
• Nav class should extend from framework Menu widget yii2-bootstrap#16: For me this makes no sense. As mentioned in issue, Nav extends Bootstrap Widget because of Bootstrap functionality. In addition the behavior of Menu and Nav are not equal. Sub navigations in Nav are Dropdowns in Menu they're still Menus

[samdark]

We haven't tagged release so BC breaks are still OK.

[simialbi]

@samdark about yiisoft/yii2-bootstrap#147:
There is still another poblem: yii\bootstrap4\ActiveField extends yii\widgets\ActiveField and yii\widgets\ActiveField has a method called dropDownList. If we'd like to be consistent, we would have to change it there too.

[samdark]

That's fine. Let's use Dropdown as a single word everywhere as it's used by bootstrap and many other libraries: https://getbootstrap.com/docs/4.1/components/dropdowns/

[simialbi]

Ok, I changed my open PR #90
What about yiisoft/yii2-bootstrap#101? Shall I add the possibility of a brand without link (span) instead of setting home link as default?

[samdark]

It's not bootstrap 4 specific so if you think it's a good move, feel free to.

[simialbi]

Now there is still:

• [docs] Improve "Compiling from the .sass files" #81: I'm not sure what's the correct way to do this. In my opinion this is very project specific. Sometimes you need bootstrap as base, sometimes you customize it...
• Change Bower to NPM & update composer.json. #85: I would prefer not to change to npm. But it's up to you

• NavBar class not easily extendable due to html in the init function yii2-bootstrap#164: I recommend not to realise this. The current class fulfills all the variants described by the documentation. In my opinion anything going further has to be customized by application, not library.
• Nav class should extend from framework Menu widget yii2-bootstrap#16: For me this makes no sense. As mentioned in issue, Nav extends Bootstrap Widget because of Bootstrap functionality. In addition the behavior of Menu and Nav are not equal. Sub navigations in Nav are Dropdowns in Menu they're still Menus

I think my part is finished. In my opinion it's ready for a release. If I can still help somewhere, just tell me...

[machour]

Thank you so much @simialbi !

#81: my initial grief was "we should not install bootstrap from npm" which is wrong. This is a docs improvement and is not blocking for the release.

#85: bower is dead. I never personally experienced the issues you're facing with npm, and have been using it with assets-packagist or foxy/foxy for months. I think it should be merged.

I agree with you for the two other issues.

[samdark]

Merged #85.

[machour]

Opened #92 & #93

[machour]

Added #95 that I'd like to discuss before the first release. Doesn't seem like much of an effort implementation wise, and comes with great benefits.

[machour]

Sadly I've been swamped with work these days.

Changes from #95 should not break BC, so I guess they could be shipped in a subsequent release.
Let's ship yii2-bootstrap4 as it is now, and enhance it later.