Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine: NumberValidator test with comma-locale fails #25

Closed
schmunk42 opened this issue Jan 19, 2018 · 2 comments
Closed

Alpine: NumberValidator test with comma-locale fails #25

schmunk42 opened this issue Jan 19, 2018 · 2 comments
Labels

Comments

@schmunk42
Copy link
Contributor

Looks like there are some more intl issues: docker-library/php#219

Failed test:

2) yiiunit\framework\validators\NumberValidatorTest::testValidateValueSimple
Failed asserting that false is true.

/yii2/tests/framework/validators/NumberValidatorTest.php:85
/yii2/vendor/phpunit/phpunit/phpunit:52

Test-source:

$this->setCommaDecimalLocale();
$this->assertTrue($val->validate('25,45'));
$this->restoreLocale();

Can someone shed some more light on this?

@samdark
Copy link
Member

samdark commented Jan 19, 2018

That test depends on particular system locale (where comma is used as decimal separator) to present in the OS. Seems in this case it's not there.

@schmunk42
Copy link
Contributor Author

Doesn't even work with this fix: https://github.com/voidlinux/void-mklive/pull/48 (which needs minutes to apply btw.)
Also related: gliderlabs/docker-alpine#144 (comment)

Given this an #24 - it looks like there'll be no official PHP Alpine images until those issues are fixed in upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants