Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript typings not correct #4

Open
kokororin opened this issue Dec 1, 2023 · 0 comments
Open

TypeScript typings not correct #4

kokororin opened this issue Dec 1, 2023 · 0 comments

Comments

@kokororin
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch chinese-workday@1.10.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/chinese-workday/index.d.ts b/node_modules/chinese-workday/index.d.ts
index b252d4d..6b6494a 100644
--- a/node_modules/chinese-workday/index.d.ts
+++ b/node_modules/chinese-workday/index.d.ts
@@ -1,5 +1,3 @@
-export interface ChineseWorkday{
-  isWorkday(day: string | Date): boolean;
-  isHoliday(day: string | Date): boolean;
-  getFestival(day: string | Date): string;
-}
+export function isWorkday(day: string | Date): boolean;
+export function isHoliday(day: string | Date): boolean;
+export function getFestival(day: string | Date): string;

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant