Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy heuristics when deciding between update and replace child #8

Open
yjbanov opened this issue Mar 20, 2017 · 0 comments
Open

Buggy heuristics when deciding between update and replace child #8

yjbanov opened this issue Mar 20, 2017 · 0 comments

Comments

@yjbanov
Copy link
Owner

yjbanov commented Mar 20, 2017

The expression in the if statement seems buggy. It seems that it will happily update a <div> with configuration for a <span> just because both are Element. Instead, we should add bool RenderNode.canUpdateFrom(Node config) and let the render node decide if it's compatible with the configuration object.

Another piece of code with the same issue:

bool _canUpdate(RenderNode node, Node configuration) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant