Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Project Manager bugs #1564

Closed
4 tasks done
iLLiCiTiT opened this issue May 23, 2021 · 11 comments
Closed
4 tasks done

Project Manager bugs #1564

iLLiCiTiT opened this issue May 23, 2021 · 11 comments
Labels
type: bug Something isn't working

Comments

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented May 23, 2021

List of bugs in Project Manager

@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label May 23, 2021
@BigRoy
Copy link
Collaborator

BigRoy commented Jun 3, 2021

FIXED

2021-06-04.00-31-40.mp4

3.0.0 tag

Hitting this bug where I can't create a sibling asset.

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 3, 2021

Visually it looks like you can change the Task type on existing saved tasks - but in practice you can't. It INCORRECTLY does propagate the change to the database.

change_task_type_on_saved_tasks.mp4

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 3, 2021

FIXED Not sure how I'm having this happen - but it tends to get to a state where pressing Save does nothing. Where should I look to see what might be causing this?

2021-06-04.00-41-51.mp4

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 3, 2021

FIXED Selecting a Task and then clicking on Add Asset crashes the tool. It takes down Pype Tray along with it.

Traceback (most recent call last):
  File "S:\openpype\OpenPype\openpype\tools\project_manager\project_manager\window.py", line 189, in _on_add_asset
    self.hierarchy_view.add_asset()
  File "S:\openpype\OpenPype\openpype\tools\project_manager\project_manager\view.py", line 404, in add_asset
    return self._source_model.add_new_asset(parent_index)
  File "S:\openpype\OpenPype\openpype\tools\project_manager\project_manager\model.py", line 396, in add_new_asset
    result = self.add_item(new_child, item, new_row)
  File "S:\openpype\OpenPype\openpype\tools\project_manager\project_manager\model.py", line 459, in add_item
    result = self.add_items([item], parent, row)
  File "S:\openpype\OpenPype\openpype\tools\project_manager\project_manager\model.py", line 440, in add_items
    parent.add_child(item, row)
  File "S:\openpype\OpenPype\openpype\tools\project_manager\project_manager\model.py", line 1949, in add_child
    raise AssertionError("BUG: Can't add children to Task")
AssertionError: BUG: Can't add children to Task

The crash could be avoided by instead maybe popping up a pop-up using sys.excepthook that shows the error instead.

@BigRoy
Copy link
Collaborator

BigRoy commented Jun 3, 2021

SOLVED Double clicking (or pressing ENTER) on the name of existing assets (that are in database) allows you to rename the asset and save it to the database. Should renaming an asset be allowed? Is this correct behavior?

By the way, I started posting multiple bugs here due to the top message saying "List of bugs" but I'm not sure whether it's alright I'm actually dropping all of these in one issue.

@iLLiCiTiT
Copy link
Member Author

iLLiCiTiT commented Jun 3, 2021

Hitting this bug where I can't create a sibling asset.

and

Not sure how I'm having this happen - but it tends to get to a state where pressing Save does nothing. Where should I look to see what might be causing this?

Fixed with: #1645

Description

  • save did not trigger refreshing of attributes holding data and asset duplications

@iLLiCiTiT
Copy link
Member Author

Double clicking (or pressing ENTER) on the name of existing assets (that are in database) allows you to rename the asset and save it to the database. Should renaming an asset be allowed? Is this correct behavior?

It won't allow to change asset name when has published content (at least one subset).

@iLLiCiTiT iLLiCiTiT changed the title Project Manager validation of duplicated children Project Manager bugs Jun 3, 2021
@iLLiCiTiT
Copy link
Member Author

Selecting a Task and then clicking on Add Asset crashes the tool. It takes down Pype Tray along with it.

Fixed with #1646

@iLLiCiTiT
Copy link
Member Author

Visually it looks like you can change the Task type on existing saved tasks - but in practice you can't. It INCORRECTLY does propagate the change to the database.

I think this was issue connected with #1645 Let me know if issue persist because it works on my side.

@iLLiCiTiT
Copy link
Member Author

By the way, I started posting multiple bugs here due to the top message saying "List of bugs" but I'm not sure whether it's alright I'm actually dropping all of these in one issue.

As it's in beta stage it is better to have it here. As you can see 2-3 issue were solved with 1 PR because were cause due to same bug cause by missing 2 lines.

@iLLiCiTiT
Copy link
Member Author

Closing as it seems that all initial bugs are fixed and all other should be reported as separated issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants