Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Pype setup refactor #211

Closed
antirotor opened this issue Jun 3, 2020 · 3 comments · Fixed by #513
Closed

Pype setup refactor #211

antirotor opened this issue Jun 3, 2020 · 3 comments · Fixed by #513
Assignees
Labels
epic type: enhancement Enhancements to existing functionality
Milestone

Comments

@antirotor
Copy link
Member

Pype setup rework

For 3.0 release we change pype-setup so it acts as installer only, all other functionality should be moved to pype (see #205).

It should wrap all dependencies using something cx_freeze.

Local installation

How to tell the installer what to install? Compare "local version" with "studio vesion"
if they don't match update all repositories by copying from studio to local.

Installing Git and Python along with all other pype-setup files able to pack all dependent data files (json, ffmpeg, plugins_folder). We could append studio local sub-releases to pype-setup/version.py
everytime local changes should be pushed to artist, we add local version token to pype-setup/config.ini

Example:

3.0.0
3.0.0-client1 (version + local_subversion)
3.0.1-client1 (version + local_subversion)
3.0.2
3.1.1
3.1.1-client1 (version + local_subversion)
3.1.1-client2 (version + local_subversion)

Move deploy.json to setup.py and config.ini
Artist shouldn't need to update pype-setup itself often. Only with any major changes, in which case he get's new zip.

@antirotor antirotor added type: enhancement Enhancements to existing functionality epic labels Jun 3, 2020
@antirotor antirotor added this to the 3.0 milestone Jun 3, 2020
@antirotor antirotor self-assigned this Jun 3, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@create-issue-branch
Copy link

Branch feature/211-Pype_setup_refactor created!

@antirotor
Copy link
Member Author

antirotor commented Jun 3, 2020

Right now it is in shell scripts (pype.ps1 and pype) for the python independent part and in pypeapp/PypeLauncher for python specifics. If we bundle our own python, we don't need most of the code in shell scripts as that can be written in python. But there is other side - if we put commands to pype repo, they (as rest of the code) depends on virtual environment set by pype-setup. Little case of egg and chicken.

I still vote to move all those command to pype and add sanity checks to prevent its run without correct environment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
epic type: enhancement Enhancements to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants