Cannot publish multiple review subsets in Maya

[antirotor]

Bug

When you create mutliple review instances in Maya, only one will be published.

To replicate

1. Create review instance main and put one camera there
2. Create another instance second and put another camera there
3. Publish ...
4. Publishing will look fine, but only one instance will be integrated

[cuID:OP-3068]

[antirotor]

This is caused by this logic:
https://github.com/pypeclub/OpenPype/blob/cdbcfadae219da6d7787d9fefd80432ff617662f/openpype/hosts/maya/plugins/publish/collect_review.py#L78-L87

Anyone remember why is it there? @mkolar perhaps?

[tokejepsen]

Anyone remember why is it there? @mkolar perhaps?

That might have been when I implemented it with Milan suggestion.

#424

[antirotor]

That might have been when I implemented it with Milan suggestion.

From 2.13 or 14, we can then switch it OFF by default. and in pype 3 remove it. what do you think?

That is probably important point in conversation ... Question is - this should be probably reworked so it conforms with new subset name templating and it has to include variant so we can fix this issue. How to work with backwards compatibility in that regard. It is little related in this regard with #2695

[tokejepsen]

Is it a direction decision that is needed to continue on this?

[antirotor]

Is it a direction decision that is needed to continue on this?

I think we need to agree on how to handle backwards compatibility.

[kalisp]

Closed by #3269