Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Publisher: add more abstract methods #4054

Closed
kalisp opened this issue Nov 1, 2022 · 2 comments · Fixed by #4298
Closed

Publisher: add more abstract methods #4054

kalisp opened this issue Nov 1, 2022 · 2 comments · Fixed by #4298
Assignees

Comments

@kalisp
Copy link
Member

kalisp commented Nov 1, 2022

Is your feature request related to a problem? Please describe.
Publisher expects more methods which are not abstract currently in any base class or interface and therefore it is a bit difficult to know that they need to be implemented.

Describe the solution you'd like
At least these methods should be added:

  • install
  • uninstall
  • get_context_data
  • update_context_data

And maybe:

  • list_instances see comment lower
  • remove_instance

These were expected for SubsetManager (for host where is not totally clear which publishable instances are there). SubsetManager is probably obsolete and replaced with Publisher.

[cuID:OP-4339]

@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Nov 1, 2022

Few notes:

  • install should not be abstract but should be available with docstring
  • uninstall is pointless method that was never used in openpype
  • get_context_data and update_context_data is abstract in IPublishHost interface
  • list_instances and remove_instance is only for SubsetManager tool which will be removed with new publisher (so it's pointless too)

@BigRoy
Copy link
Collaborator

BigRoy commented Jan 10, 2023

uninstall is pointless method that was never used in openpype

I've actually started using uninstall() in Substance Painter integration since it's installed through a Substance plug-in which the user can disable too. Not sure if that's the way to go in the long run, but just FYI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants