Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Harmony websocket server #496

Closed
jakubjezek001 opened this issue Aug 31, 2020 · 6 comments
Closed

Harmony websocket server #496

jakubjezek001 opened this issue Aug 31, 2020 · 6 comments
Assignees
Labels
host: Harmony type: enhancement Enhancements to existing functionality
Milestone

Comments

@jakubjezek001
Copy link
Member

jakubjezek001 commented Aug 31, 2020

Is your feature request related to a problem? Please describe.
integrate Harmony to websocket server

@jakubjezek001 jakubjezek001 added type: enhancement Enhancements to existing functionality host: Harmony labels Aug 31, 2020
@create-issue-branch
Copy link

Branch feature/496-Harmony_websocket_server created!

@jakubjezek001 jakubjezek001 added this to the 2.13 milestone Aug 31, 2020
@mkolar
Copy link
Member

mkolar commented Sep 17, 2020

@kalisp had a stab at this and it's proving quite difficult, maybe even impossible right now, we'll have to do more research, if it becomes higher priority. Currently it's not crucial.

@mkolar mkolar added the LOW label Sep 17, 2020
@kalisp
Copy link
Member

kalisp commented Sep 17, 2020

Summary of current state:
Harmony uses QtScripts which is based on Qt 4.8. That version doesn't have support for websockets. Qt own https://doc.qt.io/qt-5/qtwebsockets-index.html are present only after Qt 5.3.

I tried to hijack couple of libraries from Node.js, but they depend on features of ECMAScript v6, QtScripts is on 3.

Whole QtScript is actually obsolete and unsupported by Qt for a while :(.
(In PS current implementation works as they are using some browser js engine, so Websocket API is implemented by default and our used js library just extend that.)

@tokejepsen
Copy link
Member

Could the communication from Python be the websocket?
Then just implement an interpreter in Harmony.

@antirotor
Copy link
Member

This is now stabilized in ynput/avalon-core#211. It is still not ideal as 100% websocket server would be really cool, but with limitations of QtScript it is not worth to do it.

@mkolar
Copy link
Member

mkolar commented Feb 16, 2021

Closing this down as it is not really needed and too much hassle for little return

@mkolar mkolar closed this as completed Feb 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
host: Harmony type: enhancement Enhancements to existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants