This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Ftrack subprocess handle of stdout/stderr #1675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ftrack user event server is running as subprocess which cause issues with logging because all python subprocess.Popen objects have stdout and stderr which are inherited from source process, but if
openpype_gui
executable is used then sys.stdout and sys.stderr are set to None so new created processes get strange PIPE objects that can't work withPypeStreamHandler
properly and may crash at any time becauseflush
of the stream cause OSError.Changes
Why is that important
Any processed action can crash during logging (most visible when launchin application).
How to replicate issue
Hard to say. I launched Nuke 5-10 timer in row from ftrack. One of launches should crash if
openpype_gui
executable is used.Closes: https://github.com/pypeclub/client/issues/92