Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Workfile tool start at host launch support #1865

Merged
merged 7 commits into from
Jul 29, 2021
Merged

Workfile tool start at host launch support #1865

merged 7 commits into from
Jul 29, 2021

Conversation

jakubjezek001
Copy link
Member

@jakubjezek001 jakubjezek001 commented Jul 27, 2021 •
edited
Loading

Description

In pype2 used to be an option to add env var to launch workfile tool at a host launch. It was missing in openpype.

Solution

  • adding global workfile project settings with an filter on host and task name (this should be changed to task type in future)
  • adding default settings not to open the workfile tool at launch
  • adding functionality for filtering by host and task name and adding result to environment variable WORKFILE_STARTUP as it used to be
  • refactory nuke's lib function to support this back again

Testing notes

  1. open settings and go to project/global/tools/workfile/Open workfile tool at launch
  2. create new filter and set host to nuke and Enabled to True
  3. launch nuke from any of your task
  4. workfile tool should be opening

closes https://github.com/pypeclub/client/issues/126

@jakubjezek001 jakubjezek001 self-assigned this Jul 27, 2021
@jakubjezek001 jakubjezek001 added sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality host: Nuke labels Jul 27, 2021
hound[bot]
hound bot reviewed Jul 27, 2021
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last): 
Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 373, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

@jakubjezek001 jakubjezek001 mentioned this pull request Jul 27, 2021
Closed
@jakubjezek001 jakubjezek001 marked this pull request as ready for review July 27, 2021 13:28
hound[bot]
hound bot reviewed Jul 28, 2021
View reviewed changes
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Traceback (most recent call last): 
Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 363, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 371, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 373, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

openpype/lib/applications.py Show resolved Hide resolved
iLLiCiTiT
iLLiCiTiT approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jakubjezek001 jakubjezek001 merged commit 2794c67 into develop Jul 29, 2021
@jakubjezek001 jakubjezek001 deleted the feature/workfile_start_at_launch branch July 29, 2021 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hound hound[bot] hound[bot] left review comments

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Nuke sponsored Client endorsed or requested type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakubjezek001 @iLLiCiTiT