This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add timecode to slate #2929
Merged
Add timecode to slate #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-2913 Entity top-level metadata editing (dialog?) |
jrsndl
changed the title
jakubjezek001
suggested changes
Mar 22, 2022
There was a problem hiding this comment.
If DVXHD on MXF is configured in Settings
My ffmpeg output args were:
-codec:v dnxhd
-pix_fmt yuv422p
-b:v 115M
Here is Traceback:
Traceback (most recent call last):
File "C:\CODE\__PYPE\OpenPype\.venv\lib\site-packages\pyblish\plugin.py", line 522, in __explicit_process
runner(*args)
File "C:\CODE\__PYPE\OpenPype\openpype\plugins\publish\extract_review_slate.py", line 95, in process
KeyError: 'timecode'
iLLiCiTiT
reviewed
Mar 23, 2022
added 4 commits
March 28, 2022 16:48
|
Another try. Tested on Prores, DNxHD, MXF and H264 mp4, with and withouth sound. |
|
This might close Nuke: Nuke Slate MXF review fails on 23.976 FPS project #3014 |
added 4 commits
May 10, 2022 20:14
|
Hey @jrsndl, shouldn't this be marked as review ready? I had just tested it and all is working fine as expected ;) I am ready to approve and merge. |
iLLiCiTiT
reviewed
May 23, 2022
iLLiCiTiT
reviewed
May 23, 2022
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
|
Does it also fix #3014 ? |
|
|
Isn't this duplicate of #3162 ? |
…audio # Conflicts: # openpype/plugins/publish/extract_review_slate.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Add timecode to reviews with Nuke slate.
Description
Source Timecode is read from the review. Slate is assumed to be one frame. Source timecode is offseted -1 frame and added to the slate encode.
Additional info
This PR also has an initial attempt to solve adding slate to the review with audio. Concatenating slate with review with sound no longer fails, but sometimes produces two frame slate. More work is needed for clean audio concatenation.
Testing notes: