Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Settings UI: Collapsed of collapsible wrapper works as expected #2934

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Settings UI: Collapsed of collapsible wrapper works as expected #2934

merged 2 commits into from
Mar 24, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

When collapsible-wrap has set collapsed in schemas it does in UI the opposite of what it should.

Changes

  • fix usage of collapsed value in CollapsibleWrapper

Testing notes:

  1. Add collapsible-wrap item into settings schema and set it's collapsed to True
  2. Open settings UI where should the item be collapsed

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 23, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Mar 23, 2022
@iLLiCiTiT iLLiCiTiT added this to the next milestone Mar 23, 2022
@64qam
Copy link
Member

64qam commented Mar 23, 2022

When Settings starts it returns error and project settings are broken:
image


  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\categories.py", line 526, in reset
    self.add_children_gui()

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\categories.py", line 656, in add_children_gui
    item = self.create_ui_for_entity(self, child_obj, self)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\categories.py", line 144, in create_ui_for_entity
    return DictImmutableKeysWidget(*args)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\base.py", line 37, in __init__
    self.create_ui()

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\item_widgets.py", line 68, in create_ui
    self.category_widget, child_obj, self

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\base.py", line 84, in create_ui_for_entity
    return self.category_widget.create_ui_for_entity(*args, **kwargs)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\categories.py", line 144, in create_ui_for_entity
    return DictImmutableKeysWidget(*args)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\base.py", line 37, in __init__
    self.create_ui()

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\item_widgets.py", line 68, in create_ui
    self.category_widget, child_obj, self

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\base.py", line 84, in create_ui_for_entity
    return self.category_widget.create_ui_for_entity(*args, **kwargs)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\categories.py", line 144, in create_ui_for_entity
    return DictImmutableKeysWidget(*args)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\base.py", line 37, in __init__
    self.create_ui()

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\item_widgets.py", line 62, in create_ui
    self.entity.gui_layout, self.content_widget

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\item_widgets.py", line 85, in _prepare_entity_layouts
    wrapper = CollapsibleWrapper(child, widget)

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\wrapper_widgets.py", line 20, in __init__
    self.create_ui()

  File "C:\Users\qam\pypeclub\OpenPype\openpype\tools\settings\settings\wrapper_widgets.py", line 95, in create_ui
    if not self.entity.collapsed:

AttributeError: 'NoneType' object has no attribute 'collapsed'

image

@iLLiCiTiT iLLiCiTiT merged commit 437624d into develop Mar 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/collapsed_wrap_behavior branch March 24, 2022 09:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@64qam 64qam 64qam approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.9.3
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @64qam