Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Harmony: audio validator has wrong logic #3364

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Harmony: audio validator has wrong logic #3364

merged 1 commit into from
Jun 17, 2022

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jun 17, 2022

Brief description

Wrong condition stayed after change from asset to raise (it should be negated).

Testing notes:

  1. add some audio file into Harmony
  2. validator shouldnt trigger

@kalisp
Fix - audio validator for Harmony has wrong logic
d230cb7 
Wrong condition stayed after change from asset to raise (it should be negated).
@kalisp kalisp added the type: bug Something isn't working label Jun 17, 2022
@kalisp kalisp requested a review from 64qam June 17, 2022 10:41
@kalisp kalisp self-assigned this Jun 17, 2022
@kalisp kalisp merged commit a6c0063 into develop Jun 17, 2022
@kalisp kalisp deleted the bugfix/harmony_audio_validator branch June 17, 2022 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@64qam 64qam 64qam approved these changes

Assignees

@kalisp kalisp

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalisp @64qam