Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

General: Move workfiles functions into pipeline #3637

Merged

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Aug 9, 2022

Brief description

Moved workfile related logic to openpype.pipeline.workfile content.

Description

Workfile path resolving functionality like which anatomy template is used, or receiving last workfile path based on template and fill data, or handling of paths to custom template used as source for first version was moved to workfile specific file. Class BuildWorkfile was also moved to openpype.pipeline.workfile.build_workfile. Functionality to create and update workfile documents has been modified to use operations.

Testing notes:

  • Last workfile on launch should be started (if enabled)
    • project_settings/global/tools/Workfiles/last_workfile_on_startup
  • Custom template as first workfile version is used (if enabled and path is set in settings)
    • available for nuke, tvpaint, photoshop, blender, aftereffects project_settings/<host>/workfile_builder
    • if one works then all work
  • It is possible to store artist note in workfiles tool
  • Workfile building works in nuke and maya (project_settings/<host>/workfile_build/profiles)
  • It is possible to use different workfiles templates (e.g. unreal has different workfile template)
    • project_settings/global/tools/Workfiles/workfile_template_profiles

@ynbot
Copy link
Contributor

ynbot commented Aug 9, 2022

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 9, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Aug 9, 2022
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not opening last workfile (at least for PS and AE), it returns to v001 even if workfiles for much higher versions exist. (Tested it in develop and there it is opening last workfile correctly.)

@iLLiCiTiT iLLiCiTiT requested a review from kalisp August 10, 2022 12:32
@iLLiCiTiT
Copy link
Member Author

It is not opening last workfile (at least for PS and AE), it returns to v001 even if workfiles for much higher versions exist. (Tested it in develop and there it is opening last workfile correctly.)

Should be fixed. I skipped all extensions if they don't start with dot instead of fixing them...

@kalisp
Copy link
Member

kalisp commented Aug 10, 2022

Last workfile works.
Tried to test Workfile builder in Nuke, but couldnt figure how it should look like.

Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build workfile works in Nuke.

@iLLiCiTiT iLLiCiTiT merged commit e95c58e into develop Aug 12, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-3646_Move-workfiles-functions-into-pipeline branch August 12, 2022 18:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants