Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Workfiles tool deselecting a task will leave "Browse" and "Save As" button enabled #159

Open
2 tasks done
BigRoy opened this issue Mar 7, 2024 · 1 comment
Open
2 tasks done
Labels
community Issues and PRs coming from the community members type: bug Something isn't working

Comments

@BigRoy
Copy link
Collaborator

BigRoy commented Mar 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior:

Currently in Workfiles tool when deselecting a task the Save As and Browse buttons remain enabled.

Clicking Save As also gives an error, e.g.:

Traceback (most recent call last):
  File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\widgets\files_widget.py", line 253, in _on_workarea_save_clicked
    result = self._exec_save_as_dialog()
  File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\widgets\files_widget.py", line 175, in _exec_save_as_dialog
    dialog.update_context()
  File "E:\dev\ayon-core\client\ayon_core\tools\workfiles\widgets\save_as_dialog.py", line 254, in update_context
    self._extension_combobox.addItems(data["extensions"])
TypeError: 'PySide2.QtWidgets.QComboBox.addItems' called with wrong argument types:
  PySide2.QtWidgets.QComboBox.addItems(NoneType)
Supported signatures:
  PySide2.QtWidgets.QComboBox.addItems(typing.Sequence[str])

Expected Behavior:

Whenever there's no valid context (e.g. no folder + task selected) it should deactivate the irrelevant buttons.
The browse button is technically also invalid, since you wouldn't be able to open the file in a 'valid context' if you wouldn't have a task selected in the UI.

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

  1. Open workfiles tool
  2. Deselect task

image

Are there any labels you wish to add?

  • I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

@BigRoy BigRoy added the type: bug Something isn't working label Mar 7, 2024
@MustafaJafar MustafaJafar added the community Issues and PRs coming from the community members label Mar 26, 2024
@BigRoy
Copy link
Collaborator Author

BigRoy commented Jun 18, 2024

For what it's worth - this issue still appears to be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs coming from the community members type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants